From: Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>
To: Bhumika Goyal <bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: julia.lawall-L2FTfq7BK8M@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usb: musb: constify dev_pm_ops structures
Date: Tue, 17 Jan 2017 08:43:16 -0600 [thread overview]
Message-ID: <20170117144316.GD31716@uda0271908> (raw)
In-Reply-To: <1484481646-28544-1-git-send-email-bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Sun, Jan 15, 2017 at 05:30:46PM +0530, Bhumika Goyal wrote:
> Declare dev_pm_ops structures as const as they are only stored in the pm
> field of a device_driver structure. This field is of type const, so
> dev_pm_ops structures having similar properties can be declared const
> too.
>
> Size details after cross compiling the .o file for arm
> architecture.
>
> File size before: drivers/usb/musb/omap2430.o
> text data bss dec hex filename
> 4141 400 8 4549 11c5 usb/musb/omap2430.o
>
> File size after: drivers/usb/musb/omap2430.o
> text data bss dec hex filename
> 4333 200 8 4541 11bd usb/musb/omap2430.o
>
> Signed-off-by: Bhumika Goyal <bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Applied. Thanks.
[b-liu-l0cyMroinI0@public.gmane.org: added omap2430 in commit subject prefix]
-Bin.
> ---
> drivers/usb/musb/omap2430.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 8b73214..456f3e6 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -575,7 +575,7 @@ static int omap2430_runtime_resume(struct device *dev)
> return 0;
> }
>
> -static struct dev_pm_ops omap2430_pm_ops = {
> +static const struct dev_pm_ops omap2430_pm_ops = {
> .runtime_suspend = omap2430_runtime_suspend,
> .runtime_resume = omap2430_runtime_resume,
> };
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-01-17 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 12:00 [PATCH] usb: musb: constify dev_pm_ops structures Bhumika Goyal
[not found] ` <1484481646-28544-1-git-send-email-bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-17 14:43 ` Bin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117144316.GD31716@uda0271908 \
--to=b-liu-l0cymroini0@public.gmane.org \
--cc=bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=julia.lawall-L2FTfq7BK8M@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).