From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume Date: Wed, 18 Jan 2017 10:44:32 -0800 Message-ID: <20170118184432.GK7403@atomide.com> References: <20170117175524.3484-1-tony@atomide.com> <20170118142501.GA10928@uda0271908> <20170118165308.GC7403@atomide.com> <20170118181541.GJ7403@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170118181541.GJ7403-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grygorii Strashko Cc: Bin Liu , Dan Williams , Vinod Koul , Daniel Mack , Felipe Balbi , Johan Hovold , Peter Ujfalusi , Sekhar Nori , Sebastian Andrzej Siewior , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Shevchenko , Kevin Hilman , Patrick Titiano , Sergei Shtylyov List-Id: linux-omap@vger.kernel.org * Tony Lindgren [170118 10:15]: > * Grygorii Strashko [170118 10:05]: > > > > > > On 01/18/2017 10:53 AM, Tony Lindgren wrote: > > > Hi, > > > > > > * Bin Liu [170118 06:26]: > > >> With this v3, I still get -71 error when a device is plugged to a hub to > > >> musb. It doesn't happen though if the device is already plugged to the hub > > >> before attaching the hub to musb. > > >> > > >> [ 177.579300] usb 1-1: reset high-speed USB device number 2 using musb-hdrc > > >> [ 177.719308] usb 1-1: device descriptor read/64, error -71 > > >> [ 178.350297] usb 1-1.1: new high-speed USB device number 4 using musb-hdrc > > > > > > I think the -71 issue is a different regression. I've verified that v4.8.y > > > does not have this, but v4.9.y does have it. > > > > > > So far the easiest way for me to reproduce the -71 problem is by plugging > > > a USB drive into a connected hub. If I connect the hub with USB drive already > > > plugged into the hub, it does not happen. ... > > Sry, but wouldn't be more simple and safe just to drop PM runtime from this driver, > > as it is part of musb and musb PM state expected to be handled properly by PM runtime now. > > Well we still need PM runtime in cppi41 to initialize it when it gets > probed and idle it when not used even if musb modules are not loaded. > > Unfortunately until musb_cppi41.c dma calls are fixed, we can't do > any sane use counting in cppi41.c without adding timeout handling > to it. > > > More over, There is another possibility related to the current PM runtime implementation and autosuspend > > - it might introduce delay between time when musb request desc push and time when cppi will actually > > put this desc in HW queue if cppi was not active. > > For example, there might not be -71 error seen if CPPI autosuspend is disabled > > (cppi is active all the time) before plug-in hub and then USB drive. > > I already checked that. The -71 error seems to be a separate issue. OK found it. I can make v4.8.17 produce -71 errors with just commit 467d5c980709 ("usb: musb: Implement session bit based runtime PM for musb-core") applied on top of it. So looks like we're missing some musb quirk handling for the devctl session bit. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html