linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>,
	Alexandre Bailon
	<abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Andreas Kemnade <andreas-cLv4Z9ELZ06ZuzBka8ofvg@public.gmane.org>,
	Boris Brezillon
	<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Grygorii Strashko
	<grygorii.strashko-l0cyMroinI0@public.gmane.org>,
	Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Ivaylo Dimitrov
	<ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
	Laurent Pinchart
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Sergei Shtylyov
	<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41
Date: Thu, 19 Jan 2017 07:04:57 -0800	[thread overview]
Message-ID: <20170119150457.GS7403@atomide.com> (raw)
In-Reply-To: <20170119034130.GA22265@uda0271908>

* Bin Liu <b-liu-l0cyMroinI0@public.gmane.org> [170118 19:42]:
> On Wed, Jan 18, 2017 at 06:29:59PM -0800, Tony Lindgren wrote:
> > At least with the cppi41 dma, size 1 in dma transfers will just wait
> 
> In which case do you see the size 1 transfer? using testusb?
> 
> > until the device is disconnected. This causes timeouts in cppi41 dma
> > runtime PM.
> > 
> > Also the initial size 8 transfers take about 200ms to complete when
> > plugging a USB mass storage device to a hub. But we probably want to
> > keep those to avoid using PIO.
> > 
> > Fix the issue by adding a quirk for cppi41 and skip size 1 in dma if
> > set.
> 
> It is fine to bypass dma for size 1 transfers, due to the dma setup
> overhead. But I'd like to know the test case to understand why it hangs.

The test case is the same old connect a USB mass storage device to a hub.
There we see the initial size 1 transfer in the beginning. That transfer
seems to never complete with cppi41 and the transfer will stay active
until the device is disconnected. Currently we don't seem to have any
timeout mechanism in cppi41 for that.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-01-19 15:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  2:29 [PATCHv2 0/2] Two musb fixes for v4.10-rc cycle Tony Lindgren
     [not found] ` <20170119022959.30793-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-19  2:29   ` [PATCH 1/2] usb: musb: Fix host mode error -71 regression Tony Lindgren
     [not found]     ` <20170119022959.30793-2-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-20 19:23       ` Bin Liu
2017-01-19  2:29   ` [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41 Tony Lindgren
     [not found]     ` <20170119022959.30793-3-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-19  3:41       ` Bin Liu
2017-01-19 15:04         ` Tony Lindgren [this message]
     [not found]           ` <20170119150457.GS7403-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-19 15:13             ` Bin Liu
2017-01-19 15:45               ` Tony Lindgren
     [not found]                 ` <20170119154544.GT7403-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-19 16:15                   ` Tony Lindgren
     [not found]                     ` <20170119161545.GU7403-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-19 17:15                       ` Bin Liu
2017-01-19 17:18                         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170119150457.GS7403@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=andreas-cLv4Z9ELZ06ZuzBka8ofvg@public.gmane.org \
    --cc=b-liu-l0cyMroinI0@public.gmane.org \
    --cc=balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
    --cc=ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kishon-l0cyMroinI0@public.gmane.org \
    --cc=ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).