Re: [PATCH v4 6/6] usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in DSPS

Re: [PATCH v4 6/6] usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in DSPS

[Bin Liu]

+cc linux-usb list

On Mon, Jan 23, 2017 at 05:48:08PM +0100, Alexandre Bailon wrote:
> Despite the CPPI 4.1 is a generic DMA, it is tied to USB.
> On the DSPS, CPPI 4.1 interrupt's registers are in USBSS (the MUSB glue).
> Currently, to enable / disable and clear interrupts, the CPPI 4.1 driver
> maps and accesses to USBSS's register, which making CPPI 4.1 driver not
> really generic.
> Move the interrupt management to DSPS driver.
> 
> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

It seems this patch set is almost ready to go. If Vinod would ACK on
this patch, I'd like to pick it into my tree, since the rest of the set
is for musb.

Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/6] usb: musb: cppi41: Add a way to manage DMA irq

[Bin Liu]

On Mon, Jan 23, 2017 at 05:48:02PM +0100, Alexandre Bailon wrote:
> This series was "dmaengine: cppi41: Make the driver more generic".
> I have tried to separate as munch I could CPPI 4.1 MUSB driver changes.
> 
> Currently, the DMA interrupt is managed by the CPPI 4.1 driver.
> The issue here is the CPPI 4.1 driver must access to MUSB glue registers
> to manage its interrupt.
> In order to move the interrupts management from CPPI 4.1 driver to MUSB
> (and then make it more generic), update the MUSB CPPI 4.1 driver with
> changes that will help to manage DMA interrupt from MUSB driver.
> 
> Changes in v4:
> - Remove musb pointer from struct cppi, cppi41_dma_controller and
>   tusb_omap_dma.
> 
> Changes in v3:
> - Move a patch from another series to this one to avoid build error report
>   from kbuild test robot
> - Instead of adding and exporting function, add one callback and a pointer
>   to musb in struct dma_controller
> - Surround the DMA function introduced in musb_dsps with #ifdef / #endif.
> 
> Changes in v2:
> - Fix some typo in commit messages
> - Add more explanation about some changes made by patch 2 in commit message
> 
> Alexandre Bailon (6):
>   usb: musb: dma: Add a DMA completion platform callback
>   usb: musb: cppi41: Detect aborted transfers in cppi41_dma_callback()
>   usb: musb: cppi_dma: Clean up cppi structure
>   usb: musb: cppi_dma: Clean up cppi41_dma_controller structure
>   usb: musb: cppi_dma: Clean up tusb_omap_dma structure
>   usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in DSPS
> 
>  drivers/dma/cppi41.c             | 28 ++++----------
>  drivers/usb/musb/cppi_dma.c      | 26 ++++++-------
>  drivers/usb/musb/cppi_dma.h      |  1 -
>  drivers/usb/musb/musb_cppi41.c   | 48 +++++++++++++-----------
>  drivers/usb/musb/musb_dma.h      |  5 +++
>  drivers/usb/musb/musb_dsps.c     | 81 +++++++++++++++++++++++++++++++++++++++-
>  drivers/usb/musb/tusb6010_omap.c |  7 ++--
>  7 files changed, 134 insertions(+), 62 deletions(-)
> 

Please keep linux-usb list cc'd.

Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/6] usb: musb: cppi41: Add a way to manage DMA irq

[Alexandre Bailon]

On 01/23/2017 10:26 PM, Bin Liu wrote:
> On Mon, Jan 23, 2017 at 05:48:02PM +0100, Alexandre Bailon wrote:
> > This series was "dmaengine: cppi41: Make the driver more generic".
> > I have tried to separate as munch I could CPPI 4.1 MUSB driver changes.
> >
> > Currently, the DMA interrupt is managed by the CPPI 4.1 driver.
> > The issue here is the CPPI 4.1 driver must access to MUSB glue registers
> > to manage its interrupt.
> > In order to move the interrupts management from CPPI 4.1 driver to MUSB
> > (and then make it more generic), update the MUSB CPPI 4.1 driver with
> > changes that will help to manage DMA interrupt from MUSB driver.
> >
> > Changes in v4:
> > - Remove musb pointer from struct cppi, cppi41_dma_controller and
> >   tusb_omap_dma.
> >
> > Changes in v3:
> > - Move a patch from another series to this one to avoid build error report
> >   from kbuild test robot
> > - Instead of adding and exporting function, add one callback and a pointer
> >   to musb in struct dma_controller
> > - Surround the DMA function introduced in musb_dsps with #ifdef / #endif.
> >
> > Changes in v2:
> > - Fix some typo in commit messages
> > - Add more explanation about some changes made by patch 2 in commit message
> >
> > Alexandre Bailon (6):
> >   usb: musb: dma: Add a DMA completion platform callback
> >   usb: musb: cppi41: Detect aborted transfers in cppi41_dma_callback()
> >   usb: musb: cppi_dma: Clean up cppi structure
> >   usb: musb: cppi_dma: Clean up cppi41_dma_controller structure
> >   usb: musb: cppi_dma: Clean up tusb_omap_dma structure
> >   usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in DSPS
> >
> >  drivers/dma/cppi41.c             | 28 ++++----------
> >  drivers/usb/musb/cppi_dma.c      | 26 ++++++-------
> >  drivers/usb/musb/cppi_dma.h      |  1 -
> >  drivers/usb/musb/musb_cppi41.c   | 48 +++++++++++++-----------
> >  drivers/usb/musb/musb_dma.h      |  5 +++
> >  drivers/usb/musb/musb_dsps.c     | 81 +++++++++++++++++++++++++++++++++++++++-
> >  drivers/usb/musb/tusb6010_omap.c |  7 ++--
> >  7 files changed, 134 insertions(+), 62 deletions(-)
> >
>
> Please keep linux-usb list cc'd.
Sorry about that. I will be more careful.
>
> Regards,
> -Bin.
>
Regards,
Alexandre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html