Re: [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend

[Tony Lindgren <tony@atomide.com>]

* Liam Breck <liam@networkimprov.net> [170203 13:46]:
> On Fri, Feb 3, 2017 at 1:17 PM, Tony Lindgren <tony@atomide.com> wrote:
> > Cc: Liam Breck <kernel@networkimprov.net>
> > Acked-by: Mark Greer <mgreer@animalcreek.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> Acked-by: Liam Breck <kernel@networkimprov.net>

Thanks for looking though it.

> > @@ -1492,15 +1553,25 @@ static int bq24190_pm_resume(struct device *dev)
> >  {
> >         struct i2c_client *client = to_i2c_client(dev);
> >         struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
> > +       int error;
> >
> >         bdi->f_reg = 0;
> >         bdi->ss_reg = BQ24190_REG_SS_VBUS_STAT_MASK; /* impossible state */
> >
> > -       pm_runtime_get_sync(bdi->dev);
> > +       error = pm_runtime_get_sync(bdi->dev);
> > +       if (error < 0) {
> > +               pm_runtime_put_noidle(bdi->dev);
> > +               dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error);
> > +       }
> 
> Last nitpick: call put_noidle after dev_warn, as in suspend :-)

Sure, will do that and repost v3 of both patches shortly.

Regards,

Tony