From: Tony Lindgren <tony@atomide.com>
To: Liam Breck <liam@networkimprov.net>
Cc: Sebastian Reichel <sre@kernel.org>,
Liam Breck <kernel@networkimprov.net>,
"Mark A . Greer" <mgreer@animalcreek.com>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend
Date: Tue, 7 Feb 2017 08:01:57 -0800 [thread overview]
Message-ID: <20170207160157.GA21809@atomide.com> (raw)
In-Reply-To: <CAKvHMgRV=mm2XBtrNjQCvGXuAQY6n6xEKerP4eVw2izkS9C7ww@mail.gmail.com>
* Liam Breck <liam@networkimprov.net> [170203 16:25]:
> On Fri, Feb 3, 2017 at 1:17 PM, Tony Lindgren <tony@atomide.com> wrote:
> > static int bq24190_remove(struct i2c_client *client)
> > {
> > struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
> > + int error;
> >
> > - pm_runtime_get_sync(bdi->dev);
> > - bq24190_register_reset(bdi);
> > - pm_runtime_put_sync(bdi->dev);
> > + error = pm_runtime_get_sync(bdi->dev);
> > + if (error < 0) {
> > + dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error);
> > + pm_runtime_put_noidle(bdi->dev);
> > + }
> >
> > + bq24190_register_reset(bdi);
> > bq24190_sysfs_remove_group(bdi);
> > power_supply_unregister(bdi->battery);
> > power_supply_unregister(bdi->charger);
> > + pm_runtime_put_sync(bdi->dev);
> > + pm_runtime_dont_use_autosuspend(bdi->dev);
> > pm_runtime_disable(bdi->dev);
>
> I think you addressed this, but should the above be
>
> if (!error)
> pm_runtime_put_sync(bdi->dev);
Hmm yeah.. But we need to check for if (error >= 0), also in the other
places see below.
Regards,
Tony
8< --------------------
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -1487,7 +1487,8 @@ static int bq24190_remove(struct i2c_client *client)
bq24190_sysfs_remove_group(bdi);
power_supply_unregister(bdi->battery);
power_supply_unregister(bdi->charger);
- pm_runtime_put_sync(bdi->dev);
+ if (error >= 0)
+ pm_runtime_put_sync(bdi->dev);
pm_runtime_dont_use_autosuspend(bdi->dev);
pm_runtime_disable(bdi->dev);
@@ -1541,7 +1542,7 @@ static int bq24190_pm_suspend(struct device *dev)
bq24190_register_reset(bdi);
- if (!error) {
+ if (error >= 0) {
pm_runtime_mark_last_busy(bdi->dev);
pm_runtime_put_autosuspend(bdi->dev);
}
@@ -1568,7 +1569,7 @@ static int bq24190_pm_resume(struct device *dev)
bq24190_set_mode_host(bdi);
bq24190_read(bdi, BQ24190_REG_SS, &bdi->ss_reg);
- if (!error) {
+ if (error >= 0) {
pm_runtime_mark_last_busy(bdi->dev);
pm_runtime_put_autosuspend(bdi->dev);
}
--
2.11.0
next prev parent reply other threads:[~2017-02-07 16:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 0:02 [PATCHv2 0/2] Two bq24190 PM improvments Tony Lindgren
2017-01-31 0:02 ` [PATCH 1/2] power: bq24190_charger: Check the interrupt status on resume Tony Lindgren
2017-02-03 0:32 ` Liam Breck
2017-01-31 0:02 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-01-31 0:14 ` Liam Breck
2017-01-31 0:36 ` Tony Lindgren
2017-02-03 1:43 ` Liam Breck
2017-02-03 3:44 ` Tony Lindgren
2017-02-03 10:38 ` Liam Breck
2017-02-03 18:54 ` Tony Lindgren
2017-02-03 21:00 ` Liam Breck
2017-02-03 21:17 ` Tony Lindgren
2017-02-03 21:44 ` Liam Breck
2017-02-03 22:28 ` Tony Lindgren
2017-02-04 0:23 ` Liam Breck
2017-02-07 16:01 ` Tony Lindgren [this message]
2017-02-07 18:20 ` Liam Breck
-- strict thread matches above, loose matches on Subject: below --
2017-02-08 23:12 [PATCHv4 0/2] Two bq24190 PM improvments Tony Lindgren
2017-02-08 23:13 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-02-03 23:09 [PATCHv3 0/2] Two bq24190 PM improvments Tony Lindgren
2017-02-03 23:09 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-02-08 21:32 ` Tony Lindgren
2017-01-20 22:04 [PATCH 0/2] Two bq24190 PM improvments Tony Lindgren
2017-01-20 22:04 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-01-21 0:47 ` Liam Breck
2017-01-24 1:27 ` Tony Lindgren
2017-01-24 3:34 ` Liam Breck
2017-01-24 18:29 ` Tony Lindgren
2017-01-24 23:05 ` Mark Greer
2017-01-26 16:20 ` Tony Lindgren
2017-01-26 23:56 ` Liam Breck
2017-01-30 23:55 ` Tony Lindgren
2017-01-31 0:01 ` Liam Breck
2017-01-31 0:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207160157.GA21809@atomide.com \
--to=tony@atomide.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).