Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

Pavel Machek
2017-02-19T22:19:30Z

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

hi!

> >> But as said I don't think we need float or fixed point for practical systems
> >> at all.
> >
> > So you are going to loose precision. And if userspace decides to
> > calibrate it slightly differently from kernel, lost precision will
> > matter.
>
> Really?

Really.

> Example:
>
> ADC values go 100 .. 3995 (i.e. touch margin is 100 steps in pre-calibration)
>
> This is scaled to let's say 0..640.

Ok. Now userspace realizes that kernel alignemnt is off, and it would
want to scale it to 1..642. That will mean that single pixel will be
inaccessible, right?

> > No. You have to design interface such that they _can_ be improved, and
> > what you propose does not work that way.
>
> It works. Please do real world tests...

You do a real world test on N900, and propose upgrade path.

> > Yes. I want to prevent you from pushing crap into the kernel.
>
> Crap? Well, we have discussed this driver for months here on the list and
> after a lot of improvements we came up to v9.
>
> And you still think it is crap and none of the other reviewers has noticed?

I'm pretty sure you will not be able to push calibration into kernel.

> > Userspace has to know how to do the calibration _anyway_ (for
> > other hardware),
>
> What for? I do not understand which other hardware you are talking about.
>
> On our devices there is only one touch glued to the panel and that one
> has to be calibrated. Ideally before the user gets the device into his
> hands => precalibration...
>
> If you connect a digitizer, then that one has to be calibrated of course,
> but it is not glued onto the display panel. Hence it is a different
> issue.

It is actually same issue. One kernel interface should work for all
the touchscreens.

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]