From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sre@kernel.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCHv2 02/10] drm: omapdrm: panel-dsi-cm: add regulator support
Date: Fri, 17 Mar 2017 16:26:40 +0100 [thread overview]
Message-ID: <20170317152640.GH8723@amd> (raw)
In-Reply-To: <20170305004309.28259-2-sre@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 801 bytes --]
Hi!
> The N950's display requires two regulators.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 55 +++++++++++++++++++++++--
> 1 file changed, 52 insertions(+), 3 deletions(-)
> @@ -590,25 +594,43 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
> .lp_clk_max = 10000000,
> };
>
> + if (ddata->vpnl) {
> + r = regulator_enable(ddata->vpnl);
> + if (r) {
> + dev_err(&ddata->pdev->dev,
> + "failed to enable VPNL: %d\n", r);
> + goto err0;
> + }
> + }
Having err0 that just returns .. is quite confusing. Just return here?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-17 15:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 23:50 [PATCHv2 00/10] Nokia N950 basic display support Sebastian Reichel
2017-03-05 0:43 ` [PATCHv2 01/10] drm: omapdrm: panel-dsi-cm: Fix probe for device tree Sebastian Reichel
2017-03-05 0:43 ` [PATCHv2 02/10] drm: omapdrm: panel-dsi-cm: add regulator support Sebastian Reichel
2017-03-05 5:40 ` Tony Lindgren
2017-03-17 15:26 ` Pavel Machek [this message]
2017-03-05 0:43 ` [PATCHv2 03/10] Revert "drm: omapdrm: Remove manual update display support" Sebastian Reichel
2017-03-20 11:07 ` Tomi Valkeinen
2017-03-20 16:14 ` Tony Lindgren
2017-03-20 16:35 ` Tomi Valkeinen
2017-03-20 16:43 ` Tony Lindgren
2017-03-05 0:43 ` [PATCHv2 04/10] drm: omapdrm: crtc: save framedone callback from dss Sebastian Reichel
2017-03-05 5:41 ` Tony Lindgren
2017-03-05 0:43 ` [PATCHv2 05/10] drm: omapdrm: crtc: detect manually updated displays Sebastian Reichel
2017-03-05 5:42 ` Tony Lindgren
2017-03-05 0:43 ` [PATCHv2 06/10] drm: omapdrm: crtc: add support for manual " Sebastian Reichel
2017-03-05 0:43 ` [PATCHv2 07/10] drm: omapdrm: plane: update fifo size on atomic update Sebastian Reichel
2017-03-05 0:43 ` [PATCHv2 08/10] drm: omapdrm: crtc: handle framedone directly Sebastian Reichel
2017-03-17 15:26 ` Pavel Machek
2017-03-05 0:43 ` [PATCHv2 09/10] drm: omapdrm: crtc: get manual mode displays working Sebastian Reichel
2017-03-05 5:39 ` Tony Lindgren
2017-03-20 11:19 ` Tomi Valkeinen
2017-03-05 0:43 ` [PATCHv2 10/10] ARM: dts: n950: add display support Sebastian Reichel
2017-03-24 14:29 ` Tony Lindgren
2017-03-24 14:58 ` Tomi Valkeinen
2017-03-24 15:12 ` Tony Lindgren
2017-03-24 15:20 ` Tomi Valkeinen
2017-03-24 15:44 ` Tony Lindgren
2017-03-17 15:26 ` [PATCHv2 01/10] drm: omapdrm: panel-dsi-cm: Fix probe for device tree Pavel Machek
2017-03-20 11:29 ` [PATCHv2 00/10] Nokia N950 basic display support Tomi Valkeinen
2017-03-21 9:38 ` Tomi Valkeinen
2017-03-21 9:54 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317152640.GH8723@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).