From: Tony Lindgren <tony@atomide.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-omap@vger.kernel.org,
Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>
Subject: Re: [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4
Date: Sun, 19 Mar 2017 10:35:26 -0700 [thread overview]
Message-ID: <20170319173526.GD20572@atomide.com> (raw)
In-Reply-To: <87fui95gjo.fsf@miraculix.mork.no>
* Bjørn Mork <bjorn@mork.no> [170319 10:23]:
> Tony Lindgren <tony@atomide.com> writes:
> > And the v3.8 kernel also has drivers/usb/serial/mdm6600.c:
> >
> > +static const struct usb_device_id mdm6600_id_table[] = {
> > + { USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x2a70, 0xff, 0xff, 0xff) },
> > + /* MDM9600 */
> > + { USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x2e0a, 0xff, 0xff, 0xff) },
> > + { USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x900e, 0xff, 0xff, 0xff) },
> > + { },
> > +};
>
>
> Yes, looks like they consitently use ff/ff/ff for serial functions and
> ff/fb/ff for QMI functions. So adding a vendor rule seems appropriate.
OK
> > And then in drivers/usb/serial/moto_flashqsc.c:
> >
> > +static struct usb_device_id id_table[] = {
> > + {USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x2a63, 0x0a, 0, 0)},
> > + {USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x4281, 0x0a, 0, 0xfc)},
> > + {USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x2db4, 0x0a, 0, 0xfc)},
> > + {USB_DEVICE(0x22b8, 0x4260)},
> > + {USB_DEVICE(0x22b8, 0x426D)},
> > + {},
> > +};
>
> This on the other hand, is something I hope I don't have to review :)
> The 0x0a class (CDC Data) is always part of a multi-interface function,
> and you would normally match on the control interface.
No idea about that one.. Presumably we can ignore it for now :)
> > Where the 0x4260 and 0x426d seem to be for the flash mode of the
> > Wrigley3GLTE modem.
> >
> > See also lsusb -v output below. No idea if there's a Windows driver
> > .inf file for this. Most likely whatever Windows driver is just using the
> > generic Android USB driver(s). I know the USB on droid 4 can be multiplexed
> > to have MDM6600 directly accessed, but I think that's only used for
> > debugging the modem as that mode needs to be selected in the bootloader
> > temporarily using volume keys.
> >
> > With the configuration in my patch, modprobe of qmi_wwan produces four
> > wwan interfaces if that matters.
>
> And I assume they all work?
Yeah the network scan shows networks on all four interfaces.
> >> The reason I ask is that I'd hate to have reports of other Motorola
> >> devices where ff/fb/ff was used for some other USB function. Yes, that
> >> would be stupid. But still... Experience shows that we cannot rule out
> >> stupid when we consider USB descriptors.
> >
> > Yes thanks for checking. If you prefer to set it up in some other
> > way, or need more info, please let me know.
>
> No, it all looks very sane to me, given your explanation. Just wanted to
> be absolutely sure. Thanks a lot.
>
>
> Acked-by: Bjørn Mork <bjorn@mork.no>
OK thanks,
Tony
next prev parent reply other threads:[~2017-03-19 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 16:19 [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4 Tony Lindgren
2017-03-19 16:31 ` Bjørn Mork
2017-03-19 17:02 ` Tony Lindgren
2017-03-19 17:10 ` Tony Lindgren
2017-03-19 17:20 ` Bjørn Mork
2017-03-19 17:35 ` Tony Lindgren [this message]
2017-03-22 2:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170319173526.GD20572@atomide.com \
--to=tony@atomide.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=linux-omap@vger.kernel.org \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).