From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com, peter.ujfalusi@ti.com,
julia.lawall@lip6.fr, broonie@kernel.org,
linux-omap@vger.kernel.org, Bhumika Goyal <bhumirks@gmail.com>
Subject: Re: [PATCH] ASoC: omap: constify snd_soc_ops structures
Date: Mon, 20 Mar 2017 08:29:05 +0200 [thread overview]
Message-ID: <20170320062905.GA4334@bitmer.com> (raw)
In-Reply-To: <20170320005326.7gkckcy4rbgqij3h@earth>
On Mon, Mar 20, 2017 at 01:53:26AM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Sat, Mar 18, 2017 at 07:34:11PM +0530, Bhumika Goyal wrote:
> > Declare snd_soc_ops structures as const as they are only stored
> > in the ops field of a snd_soc_dai_link structure. This field is
> > of type const, so snd_soc_ops structures having this property
> > can be made const too.
> >
> > Cross compiled the .o files for arm architecture.
> >
> > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>
> I actually noticed this while working on Droid 4's sound support and
> added this to my TODO list - stroking it off again now :)
>
> Reviewed-by: Sebastian Reichel <sre@kernel.org>
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
prev parent reply other threads:[~2017-03-20 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 14:04 [PATCH] ASoC: omap: constify snd_soc_ops structures Bhumika Goyal
2017-03-20 0:53 ` Sebastian Reichel
2017-03-20 6:29 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320062905.GA4334@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=broonie@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).