From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>, Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>
Subject: [PATCH 3/4] mfd: cpcap: Use ack_invert interrupts
Date: Wed, 22 Mar 2017 10:10:51 -0700 [thread overview]
Message-ID: <20170322171052.7006-4-tony@atomide.com> (raw)
In-Reply-To: <20170322171052.7006-1-tony@atomide.com>
We should use ack_invert as the int_read_and_clear() in the Motorola
kernel tree does "ireg_val & ~mreg_val" before writing to the mask
register.
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Tested-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/mfd/motorola-cpcap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
--- a/drivers/mfd/motorola-cpcap.c
+++ b/drivers/mfd/motorola-cpcap.c
@@ -72,6 +72,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
.mask_base = CPCAP_REG_MIM1,
.use_ack = true,
.handle_reread = true,
+ .ack_invert = true,
},
{
.name = "cpcap-m2",
@@ -81,6 +82,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
.mask_base = CPCAP_REG_MIM2,
.use_ack = true,
.handle_reread = true,
+ .ack_invert = true,
},
{
.name = "cpcap1-4",
@@ -91,6 +93,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
.type_base = CPCAP_REG_INTS1,
.use_ack = true,
.handle_reread = true,
+ .ack_invert = true,
},
};
--
2.11.1
next prev parent reply other threads:[~2017-03-22 17:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 17:10 [PATCHv2 0/4] Regmap IRQ fix and related changes CPCAP Tony Lindgren
2017-03-22 17:10 ` [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread Tony Lindgren
2017-03-27 17:49 ` Mark Brown
2017-03-28 0:36 ` Tony Lindgren
2017-03-28 15:18 ` Mark Brown
2017-03-28 15:47 ` Tony Lindgren
2017-03-28 16:49 ` Mark Brown
2017-03-28 17:10 ` Tony Lindgren
2017-04-04 3:03 ` Tony Lindgren
2017-04-04 12:19 ` Mark Brown
2017-04-04 13:56 ` Tony Lindgren
2017-04-04 15:28 ` Mark Brown
2017-04-03 11:27 ` Lee Jones
2017-03-22 17:10 ` [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts Tony Lindgren
2017-04-03 10:21 ` Lee Jones
2017-04-03 14:14 ` Tony Lindgren
2017-04-03 14:32 ` Lee Jones
2017-04-04 3:17 ` Tony Lindgren
2017-03-22 17:10 ` Tony Lindgren [this message]
2017-04-03 10:21 ` [PATCH 3/4] mfd: cpcap: Use ack_invert interrupts Lee Jones
2017-03-22 17:10 ` [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Tony Lindgren
2017-04-03 10:21 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2017-03-17 0:36 [PATCH 0/4] Regmap IRQ fix and related changes CPCAP Tony Lindgren
2017-03-17 0:36 ` [PATCH 3/4] mfd: cpcap: Use ack_invert interrupts Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322171052.7006-4-tony@atomide.com \
--to=tony@atomide.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).