From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv2 9/9] ARM: dts: omap4: convert to use the new clkctrl clocks for the drivers Date: Mon, 27 Mar 2017 17:18:00 -0700 Message-ID: <20170328001800.GR10760@atomide.com> References: <1489741781-12816-1-git-send-email-t-kristo@ti.com> <1489741781-12816-10-git-send-email-t-kristo@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1489741781-12816-10-git-send-email-t-kristo@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tero Kristo Cc: mturquette@baylibre.com, linux-omap@vger.kernel.org, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org * Tero Kristo [170317 02:12]: > Convert the drivers to use the new clkctrl clocks. > > Signed-off-by: Tero Kristo > --- > arch/arm/boot/dts/omap4.dtsi | 164 ++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 146 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 3ecf616..c39304a 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -94,16 +94,22 @@ > compatible = "ti,omap4-mpu"; > ti,hwmods = "mpu"; > sram = <&ocmcram>; > + clocks = <&mpuss_clkctrl OMAP4_MPU_CLKCTRL 0>; > + clock-names = "clkctrl"; > }; Oh one more thing. I don't think we should add the clocks here as they are now wrongly allocated to the device within the interconnect target module. These clocks really belong to each interconnect target module that we don't have in the dts yet. So we're better off adding the clockctrl clocks and then changing the dts to use the interconnect target modules with the clockctrl clocks. Regards, Tony