From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Date: Mon, 3 Apr 2017 11:21:51 +0100 Message-ID: <20170403102151.t7hycmw3hd7mz5vx@dell> References: <20170322171052.7006-1-tony@atomide.com> <20170322171052.7006-5-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170322171052.7006-5-tony@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Charles Keepax , Marcel Partap , Michael Scott , Sebastian Reichel List-Id: linux-omap@vger.kernel.org On Wed, 22 Mar 2017, Tony Lindgren wrote: > The cpcap INTS registers are for getting the value of the line, > not for configuring the type. > > Cc: Charles Keepax > Cc: Lee Jones > Cc: Marcel Partap > Cc: Michael Scott > Cc: Sebastian Reichel > Reviewed-By: Sebastian Reichel > Tested-by: Sebastian Reichel > Acked-by: Lee Jones > Signed-off-by: Tony Lindgren > --- > drivers/mfd/motorola-cpcap.c | 1 - > 1 file changed, 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c > --- a/drivers/mfd/motorola-cpcap.c > +++ b/drivers/mfd/motorola-cpcap.c > @@ -90,7 +90,6 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = { > .status_base = CPCAP_REG_INT1, > .ack_base = CPCAP_REG_INT1, > .mask_base = CPCAP_REG_INTM1, > - .type_base = CPCAP_REG_INTS1, > .use_ack = true, > .handle_reread = true, > .ack_invert = true, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog