From: Tony Lindgren <tony@atomide.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
arm@kernel.org, Nicolas Pitre <nico@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Krzysztof Halasa <khalasa@piap.pl>,
Rajendra Nayak <rnayak@codeaurora.org>,
Paul Walmsley <paul@pwsan.com>, Viresh Kumar <vireshk@kernel.org>,
Wenyou Yang <wenyou.yang@atmel.com>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: remove duplicate 'const' annotations'
Date: Thu, 11 May 2017 07:44:07 -0700 [thread overview]
Message-ID: <20170511144406.GS3489@atomide.com> (raw)
In-Reply-To: <20170511115852.t33446wrsxedmomw@piout.net>
* Alexandre Belloni <alexandre.belloni@free-electrons.com> [170511 05:02]:
> On 11/05/2017 at 13:50:16 +0200, Arnd Bergmann wrote:
> > gcc-7 warns about some declarations that are more 'const' than necessary:
> >
> > arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > static const struct of_device_id const ramc_ids[] __initconst = {
> > arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > static const struct of_device_id const bcm_kona_smc_ids[] __initconst = {
> > arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > static const struct of_device_id const timer_of_match[] __initconst = {
> > arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = {
> > arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = {
> >
> > The ones in arch/arm were apparently all introduced accidentally by one
> > commit that correctly marked a lot of variables as __initconst.
> >
> > Cc: Nicolas Pitre <nico@linaro.org>
> > Fixes: 19c233b79d1a ("ARM: appropriate __init annotation for const data")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2017-05-11 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 11:50 [PATCH] ARM: remove duplicate 'const' annotations' Arnd Bergmann
2017-05-11 11:58 ` Alexandre Belloni
2017-05-11 14:44 ` Tony Lindgren [this message]
2017-05-11 15:07 ` Nicolas Pitre
2017-05-11 17:20 ` Florian Fainelli
2017-05-12 4:24 ` Viresh Kumar
2017-05-12 4:42 ` Krzysztof Hałasa
2017-05-19 8:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511144406.GS3489@atomide.com \
--to=tony@atomide.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nico@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=olof@lixom.net \
--cc=paul@pwsan.com \
--cc=rjui@broadcom.com \
--cc=rnayak@codeaurora.org \
--cc=sbranden@broadcom.com \
--cc=vireshk@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox