From: Vinod Koul <vinod.koul@intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: b-liu@ti.com, tony@atomide.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
balbi@kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
dmaengine@vger.kernel.org, dan.j.williams@intel.com
Subject: Re: [PATCH v3 1/9] dmaengine: omap-dma: port_window support correction for both direction
Date: Sun, 14 May 2017 18:40:08 +0530 [thread overview]
Message-ID: <20170514131008.GL6263@localhost> (raw)
In-Reply-To: <20170512135752.1800-2-peter.ujfalusi@ti.com>
On Fri, May 12, 2017 at 04:57:44PM +0300, Peter Ujfalusi wrote:
> When the port_window support was verified it was done on setup where only
> the MEM_TO_DEV direction was enabled. This got un-noticed and thus only
> this direction worked.
>
> Now that I have managed to get a setup to verify both direction it turned
> out that the setup was incorrect:
> omap_desc members are settings for the slave port while the omap_sg members
> apply to the memory side of the sDMA setup.
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2017-05-14 13:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 13:57 [PATCH v3 0/9] usb: musb: tusb6010_omap: Convert to DMAengine Peter Ujfalusi
2017-05-12 13:57 ` [PATCH v3 1/9] dmaengine: omap-dma: port_window support correction for both direction Peter Ujfalusi
2017-05-14 13:10 ` Vinod Koul [this message]
[not found] ` <20170512135752.1800-1-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2017-05-12 13:57 ` [PATCH v3 2/9] usb: musb: Add quirk to avoid skb reserve in gadget mode Peter Ujfalusi
2017-05-12 13:57 ` [PATCH v3 3/9] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks Peter Ujfalusi
2017-05-17 20:08 ` Bin Liu
2017-05-12 13:57 ` [PATCH v3 4/9] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program Peter Ujfalusi
2017-05-12 13:57 ` [PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters Peter Ujfalusi
2017-05-17 20:17 ` Bin Liu
[not found] ` <20170512135752.1800-6-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2017-05-17 20:35 ` Bin Liu
2017-05-12 13:57 ` [PATCH v3 6/9] usb: musb: tusb6010_omap: Allocate DMA channels upfront Peter Ujfalusi
2017-05-12 13:57 ` [PATCH v3 7/9] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well Peter Ujfalusi
2017-05-12 13:57 ` [PATCH v3 8/9] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines Peter Ujfalusi
2017-05-12 13:57 ` [PATCH v3 9/9] usb: musb: tusb6010_omap: Convert to DMAengine API Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170514131008.GL6263@localhost \
--to=vinod.koul@intel.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).