From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: b-liu@ti.com, tony@atomide.com, gregkh@linuxfoundation.org,
vinod.koul@intel.com
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
balbi@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 4/9] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program
Date: Thu, 18 May 2017 16:12:02 +0300 [thread overview]
Message-ID: <20170518131207.23046-5-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20170518131207.23046-1-peter.ujfalusi@ti.com>
Having one musb_ep_select() instead the two calls in if/else is the same
thing, but makes the code a bit simpler to follow.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Tony Lindgren <tony@atomide.com>
---
drivers/usb/musb/tusb6010_omap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c
index 7870b37e0ea5..025b52e0b34d 100644
--- a/drivers/usb/musb/tusb6010_omap.c
+++ b/drivers/usb/musb/tusb6010_omap.c
@@ -368,15 +368,14 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz,
/*
* Prepare MUSB for DMA transfer
*/
+ musb_ep_select(mbase, chdat->epnum);
if (chdat->tx) {
- musb_ep_select(mbase, chdat->epnum);
csr = musb_readw(hw_ep->regs, MUSB_TXCSR);
csr |= (MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAENAB
| MUSB_TXCSR_DMAMODE | MUSB_TXCSR_MODE);
csr &= ~MUSB_TXCSR_P_UNDERRUN;
musb_writew(hw_ep->regs, MUSB_TXCSR, csr);
} else {
- musb_ep_select(mbase, chdat->epnum);
csr = musb_readw(hw_ep->regs, MUSB_RXCSR);
csr |= MUSB_RXCSR_DMAENAB;
csr &= ~(MUSB_RXCSR_AUTOCLEAR | MUSB_RXCSR_DMAMODE);
--
2.13.0
next prev parent reply other threads:[~2017-05-18 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 13:11 [PATCH v4 0/9] usb: musb: tusb6010_omap: Convert to DMAengine Peter Ujfalusi
2017-05-18 13:11 ` [PATCH v4 1/9] dmaengine: omap-dma: port_window support correction for both direction Peter Ujfalusi
2017-05-18 13:12 ` [PATCH v4 2/9] usb: musb: Add quirk to avoid skb reserve in gadget mode Peter Ujfalusi
2017-05-18 13:12 ` [PATCH v4 3/9] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks Peter Ujfalusi
2017-05-18 13:12 ` Peter Ujfalusi [this message]
[not found] ` <20170518131207.23046-1-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2017-05-18 13:12 ` [PATCH v4 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters Peter Ujfalusi
2017-05-18 13:12 ` [PATCH v4 8/9] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines Peter Ujfalusi
2017-05-18 13:12 ` [PATCH v4 6/9] usb: musb: tusb6010_omap: Allocate DMA channels upfront Peter Ujfalusi
2017-05-18 13:12 ` [PATCH v4 7/9] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well Peter Ujfalusi
2017-05-18 13:12 ` [PATCH v4 9/9] usb: musb: tusb6010_omap: Convert to DMAengine API Peter Ujfalusi
2017-05-30 15:53 ` [PATCH v4 0/9] usb: musb: tusb6010_omap: Convert to DMAengine Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518131207.23046-5-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox