* [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property
@ 2017-06-12 7:20 Tony Lindgren
2017-06-12 14:22 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2017-06-12 7:20 UTC (permalink / raw)
To: Sebastian Reichel
Cc: linux-pm, linux-omap, devicetree, Marcel Partap, Michael Scott
The binding for cpcap-battery is missing the standard power-supplies
property as noted by Sebastian Reichel <sebastian.reichel@collabora.co.uk>.
Cc: devicetree@vger.kernel.org
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
--- a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
+++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
@@ -8,6 +8,7 @@ Required properties:
- io-channels: IIO ADC channel specifier for each name in io-channel-names
- io-channel-names: Should contain the following entries:
"battdetb", "battp", "chg_isense", "batti"
+- power-supplies: List of devices that supply power, typically cpcap_charger
Example:
@@ -24,4 +25,5 @@ cpcap_battery: battery {
&cpcap_adc 5 &cpcap_adc 6>;
io-channel-names = "battdetb", "battp",
"chg_isense", "batti";
+ power-supplies = <&cpcap_charger>;
};
--
2.13.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property
2017-06-12 7:20 [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property Tony Lindgren
@ 2017-06-12 14:22 ` Sebastian Reichel
2017-06-12 16:04 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2017-06-12 14:22 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-pm, linux-omap, devicetree, Marcel Partap, Michael Scott
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
Hi,
On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> The binding for cpcap-battery is missing the standard power-supplies
> property as noted by Sebastian Reichel <sebastian.reichel@collabora.co.uk>.
>
> Cc: devicetree@vger.kernel.org
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> --- a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> @@ -8,6 +8,7 @@ Required properties:
> - io-channels: IIO ADC channel specifier for each name in io-channel-names
> - io-channel-names: Should contain the following entries:
> "battdetb", "battp", "chg_isense", "batti"
> +- power-supplies: List of devices that supply power, typically cpcap_charger
This is missing the info, that its about phandles. Maybe:
- power-supplies: List of phandles for power-supplying devices, as
described in power_supply.txt. Typically a reference
to cpcap_charger.
-- Sebastian
>
> Example:
>
> @@ -24,4 +25,5 @@ cpcap_battery: battery {
> &cpcap_adc 5 &cpcap_adc 6>;
> io-channel-names = "battdetb", "battp",
> "chg_isense", "batti";
> + power-supplies = <&cpcap_charger>;
> };
> --
> 2.13.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property
2017-06-12 14:22 ` Sebastian Reichel
@ 2017-06-12 16:04 ` Tony Lindgren
[not found] ` <20170612160400.GY3730-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2017-06-12 16:04 UTC (permalink / raw)
To: Sebastian Reichel
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Marcel Partap, Michael Scott
* Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> [170612 07:26]:
> On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> > +- power-supplies: List of devices that supply power, typically cpcap_charger
>
> This is missing the info, that its about phandles. Maybe:
>
> - power-supplies: List of phandles for power-supplying devices, as
> described in power_supply.txt. Typically a reference
> to cpcap_charger.
Sure, updated patch below.
Regards,
Tony
8< ------
>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Date: Mon, 12 Jun 2017 00:13:45 -0700
Subject: [PATCH] dt-bindings: power: supply: cpcap-battery: Add
power-supplies property
The binding for cpcap-battery is missing the standard power-supplies
property as noted by Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>.
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>
Cc: Michael Scott <michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
---
Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
--- a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
+++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
@@ -8,6 +8,9 @@ Required properties:
- io-channels: IIO ADC channel specifier for each name in io-channel-names
- io-channel-names: Should contain the following entries:
"battdetb", "battp", "chg_isense", "batti"
+- power-supplies: List of phandles for power-supplying devices, as
+ described in power_supply.txt. Typically a reference
+ to cpcap_charger.
Example:
@@ -24,4 +27,5 @@ cpcap_battery: battery {
&cpcap_adc 5 &cpcap_adc 6>;
io-channel-names = "battdetb", "battp",
"chg_isense", "batti";
+ power-supplies = <&cpcap_charger>;
};
--
2.13.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property
[not found] ` <20170612160400.GY3730-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
@ 2017-06-15 12:54 ` Sebastian Reichel
2017-06-18 14:04 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2017-06-15 12:54 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Marcel Partap, Michael Scott
[-- Attachment #1: Type: text/plain, Size: 2670 bytes --]
Hi,
On Mon, Jun 12, 2017 at 09:04:00AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> [170612 07:26]:
> > On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> > > +- power-supplies: List of devices that supply power, typically cpcap_charger
> >
> > This is missing the info, that its about phandles. Maybe:
> >
> > - power-supplies: List of phandles for power-supplying devices, as
> > described in power_supply.txt. Typically a reference
> > to cpcap_charger.
>
> Sure, updated patch below.
I queued that one.
-- Sebastian
> 8< ------
> From tony Mon Sep 17 00:00:00 2001
> From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> Date: Mon, 12 Jun 2017 00:13:45 -0700
> Subject: [PATCH] dt-bindings: power: supply: cpcap-battery: Add
> power-supplies property
>
> The binding for cpcap-battery is missing the standard power-supplies
> property as noted by Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>.
>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>
> Cc: Michael Scott <michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> ---
> Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> --- a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> @@ -8,6 +8,9 @@ Required properties:
> - io-channels: IIO ADC channel specifier for each name in io-channel-names
> - io-channel-names: Should contain the following entries:
> "battdetb", "battp", "chg_isense", "batti"
> +- power-supplies: List of phandles for power-supplying devices, as
> + described in power_supply.txt. Typically a reference
> + to cpcap_charger.
>
> Example:
>
> @@ -24,4 +27,5 @@ cpcap_battery: battery {
> &cpcap_adc 5 &cpcap_adc 6>;
> io-channel-names = "battdetb", "battp",
> "chg_isense", "batti";
> + power-supplies = <&cpcap_charger>;
> };
> --
> 2.13.0
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property
[not found] ` <20170612160400.GY3730-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-06-15 12:54 ` Sebastian Reichel
@ 2017-06-18 14:04 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2017-06-18 14:04 UTC (permalink / raw)
To: Tony Lindgren
Cc: Sebastian Reichel, linux-pm-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Marcel Partap, Michael Scott
On Mon, Jun 12, 2017 at 09:04:00AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> [170612 07:26]:
> > On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> > > +- power-supplies: List of devices that supply power, typically cpcap_charger
> >
> > This is missing the info, that its about phandles. Maybe:
> >
> > - power-supplies: List of phandles for power-supplying devices, as
> > described in power_supply.txt. Typically a reference
> > to cpcap_charger.
>
> Sure, updated patch below.
>
> Regards,
>
> Tony
>
> 8< ------
> From tony Mon Sep 17 00:00:00 2001
> From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> Date: Mon, 12 Jun 2017 00:13:45 -0700
> Subject: [PATCH] dt-bindings: power: supply: cpcap-battery: Add
> power-supplies property
>
> The binding for cpcap-battery is missing the standard power-supplies
> property as noted by Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>.
>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>
> Cc: Michael Scott <michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> ---
> Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-18 14:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-12 7:20 [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property Tony Lindgren
2017-06-12 14:22 ` Sebastian Reichel
2017-06-12 16:04 ` Tony Lindgren
[not found] ` <20170612160400.GY3730-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-06-15 12:54 ` Sebastian Reichel
2017-06-18 14:04 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).