[GIT PULL] clk: ti: clkctrl support for 4.13 merge window

[GIT PULL] clk: ti: clkctrl support for 4.13 merge window

[Tero Kristo]

Hi Stephen, Mike,

This pull contains the v3 of the clkctrl base driver support posted 
couple of weeks back, with Tony's acks added to patch #2 and #4.

-Tero

===============================================

The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6:

   Linux 4.12-rc1 (2017-05-13 13:19:49 -0700)

are available in the git repository at:

   https://github.com/t-kristo/linux-pm.git for-4.13-ti-clkctrl

for you to fetch changes up to 19b5ebbe7680a754e3bf6ad80f3b8e9dd91a8463:

   clk: ti: omap4: add clkctrl clock data (2017-06-08 17:46:32 +0300)

----------------------------------------------------------------
Tero Kristo (3):
       clk: ti: add support for clkctrl clocks
       dt-bindings: clk: add omap4 clkctrl definitions
       clk: ti: omap4: add clkctrl clock data

Tony Lindgren (1):
       Documentation: dt-bindings: Add binding documentation for TI 
clkctrl clocks

  .../devicetree/bindings/clock/ti-clkctrl.txt       |  56 ++
  drivers/clk/ti/Makefile                            |   3 +-
  drivers/clk/ti/clk-44xx.c                          | 663 
+++++++++++++++++++++
  drivers/clk/ti/clkctrl.c                           | 486 +++++++++++++++
  drivers/clk/ti/clock.h                             |  31 +
  include/dt-bindings/clock/omap4.h                  | 146 +++++
  6 files changed, 1384 insertions(+), 1 deletion(-)
  create mode 100644 Documentation/devicetree/bindings/clock/ti-clkctrl.txt
  create mode 100644 drivers/clk/ti/clkctrl.c
  create mode 100644 include/dt-bindings/clock/omap4.h

Re: [GIT PULL] clk: ti: clkctrl support for 4.13 merge window

[Stephen Boyd]

On 06/08, Tero Kristo wrote:
> Hi Stephen, Mike,
> 
> This pull contains the v3 of the clkctrl base driver support posted
> couple of weeks back, with Tony's acks added to patch #2 and #4.
> 
> -Tero
> 

drivers/clk/ti/clkctrl.c:252
_ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
drivers/clk/ti/clkctrl.c:264
_ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
drivers/clk/ti/clkctrl.c:466
_ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
drivers/clk/ti/clkctrl.c:473
_ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'

Can these be silenced with some follow up patch? I'll hold off on
the pull until you can take a look.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [GIT PULL] clk: ti: clkctrl support for 4.13 merge window

[Tero Kristo]

On 14/06/17 20:32, Stephen Boyd wrote:
> On 06/08, Tero Kristo wrote:
>> Hi Stephen, Mike,
>>
>> This pull contains the v3 of the clkctrl base driver support posted
>> couple of weeks back, with Tony's acks added to patch #2 and #4.
>>
>> -Tero
>>
> 
> drivers/clk/ti/clkctrl.c:252
> _ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
> drivers/clk/ti/clkctrl.c:264
> _ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
> drivers/clk/ti/clkctrl.c:466
> _ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
> drivers/clk/ti/clkctrl.c:473
> _ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
> 
> Can these be silenced with some follow up patch? I'll hold off on
> the pull until you can take a look.
> 

What is the tool you use to get these?

They seem like valid warnings though, some cleanup could be used for the 
dynamic memory handling. I'll fix these tomorrow.

-Tero

Re: [GIT PULL] clk: ti: clkctrl support for 4.13 merge window

[Stephen Boyd]

On 06/14, Tero Kristo wrote:
> On 14/06/17 20:32, Stephen Boyd wrote:
> >On 06/08, Tero Kristo wrote:
> >>Hi Stephen, Mike,
> >>
> >>This pull contains the v3 of the clkctrl base driver support posted
> >>couple of weeks back, with Tony's acks added to patch #2 and #4.
> >>
> >>-Tero
> >>
> >
> >drivers/clk/ti/clkctrl.c:252
> >_ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
> >drivers/clk/ti/clkctrl.c:264
> >_ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
> >drivers/clk/ti/clkctrl.c:466
> >_ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
> >drivers/clk/ti/clkctrl.c:473
> >_ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
> >
> >Can these be silenced with some follow up patch? I'll hold off on
> >the pull until you can take a look.
> >
> 
> What is the tool you use to get these?
> 
> They seem like valid warnings though, some cleanup could be used for
> the dynamic memory handling. I'll fix these tomorrow.
> 

I use smatch[1] although I don't always have the most up to date
version.

[1] git://repo.or.cz/smatch.git

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [GIT PULL] clk: ti: clkctrl support for 4.13 merge window

[Tero Kristo]

On 14/06/17 20:49, Stephen Boyd wrote:
> On 06/14, Tero Kristo wrote:
>> On 14/06/17 20:32, Stephen Boyd wrote:
>>> On 06/08, Tero Kristo wrote:
>>>> Hi Stephen, Mike,
>>>>
>>>> This pull contains the v3 of the clkctrl base driver support posted
>>>> couple of weeks back, with Tony's acks added to patch #2 and #4.
>>>>
>>>> -Tero
>>>>
>>>
>>> drivers/clk/ti/clkctrl.c:252
>>> _ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
>>> drivers/clk/ti/clkctrl.c:264
>>> _ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
>>> drivers/clk/ti/clkctrl.c:466
>>> _ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
>>> drivers/clk/ti/clkctrl.c:473
>>> _ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
>>>
>>> Can these be silenced with some follow up patch? I'll hold off on
>>> the pull until you can take a look.
>>>
>>
>> What is the tool you use to get these?
>>
>> They seem like valid warnings though, some cleanup could be used for
>> the dynamic memory handling. I'll fix these tomorrow.
>>
> 
> I use smatch[1] although I don't always have the most up to date
> version.
> 
> [1] git://repo.or.cz/smatch.git
> 

Ok thanks, fixed and posted a new version of patch #2 of the series. 
Also force pushed this branch with the updated version in case you want 
to use this.

-Tero

Re: [GIT PULL] clk: ti: clkctrl support for 4.13 merge window

[Stephen Boyd]

On 06/15, Tero Kristo wrote:
> On 14/06/17 20:49, Stephen Boyd wrote:
> >On 06/14, Tero Kristo wrote:
> >>On 14/06/17 20:32, Stephen Boyd wrote:
> >>>On 06/08, Tero Kristo wrote:
> >>>>Hi Stephen, Mike,
> >>>>
> >>>>This pull contains the v3 of the clkctrl base driver support posted
> >>>>couple of weeks back, with Tony's acks added to patch #2 and #4.
> >>>>
> >>>>-Tero
> >>>>
> >>>
> >>>drivers/clk/ti/clkctrl.c:252
> >>>_ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
> >>>drivers/clk/ti/clkctrl.c:264
> >>>_ti_clkctrl_clk_register() warn: possible memory leak of 'clkctrl_clk'
> >>>drivers/clk/ti/clkctrl.c:466
> >>>_ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
> >>>drivers/clk/ti/clkctrl.c:473
> >>>_ti_omap4_clkctrl_setup() warn: possible memory leak of 'clkctrl_clk'
> >>>
> >>>Can these be silenced with some follow up patch? I'll hold off on
> >>>the pull until you can take a look.
> >>>
> >>
> >>What is the tool you use to get these?
> >>
> >>They seem like valid warnings though, some cleanup could be used for
> >>the dynamic memory handling. I'll fix these tomorrow.
> >>
> >
> >I use smatch[1] although I don't always have the most up to date
> >version.
> >
> >[1] git://repo.or.cz/smatch.git
> >
> 
> Ok thanks, fixed and posted a new version of patch #2 of the series.
> Also force pushed this branch with the updated version in case you
> want to use this.
> 

Thanks. Pulled into clk-next now.
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project