From: Johan Hovold <johan@kernel.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Keerthy J <j-keerthy@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for pm33xx
Date: Mon, 3 Jul 2017 18:58:44 +0200 [thread overview]
Message-ID: <20170703165844.GD27842@localhost> (raw)
In-Reply-To: <20170519200438.9502-6-d-gerlach@ti.com>
On Fri, May 19, 2017 at 03:04:38PM -0500, Dave Gerlach wrote:
> Add amx3_common_pm_init to create a dummy platform_device for
> pm33xx so that our pm33xx module can probe and am335x and am437x
> platforms to enable basic suspend to mem and standby support.
>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
> +void __init amx3_common_pm_init(void)
> +{
> + struct platform_device_info devinfo = { };
You should make sure devinfo is zeroed, and also set .id to -1.
> + struct am33xx_pm_platform_data *pdata;
> +
> + pdata = am33xx_pm_get_pdata();
> + devinfo.name = "pm33xx";
> + devinfo.data = pdata;
> + devinfo.size_data = sizeof(*pdata);
> + platform_device_register_full(&devinfo);
> +}
Johan
next prev parent reply other threads:[~2017-07-03 16:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 20:04 [PATCH v2 0/5] ARM: OMAP2+: AM33XX/AM43XX: Add suspend-resume support Dave Gerlach
2017-05-19 20:04 ` [PATCH v2 1/5] ARM: OMAP2+: Introduce low-level suspend code for AM33XX Dave Gerlach
2017-05-19 20:04 ` [PATCH v2 2/5] ARM: OMAP2+: Introduce low-level suspend code for AM43XX Dave Gerlach
2017-05-19 20:04 ` [PATCH v2 3/5] ARM: OMAP2+: pm33xx-core: Add platform code needed for PM Dave Gerlach
2017-05-22 14:56 ` Tony Lindgren
2017-07-04 13:14 ` Johan Hovold
2017-07-06 19:02 ` Dave Gerlach
2017-05-19 20:04 ` [PATCH v2 4/5] soc: ti: Add pm33xx driver for basic suspend support Dave Gerlach
2017-07-03 16:54 ` Johan Hovold
2017-07-04 13:46 ` Johan Hovold
2017-07-06 19:08 ` Dave Gerlach
2017-07-10 11:46 ` Johan Hovold
2017-05-19 20:04 ` [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for pm33xx Dave Gerlach
2017-07-03 16:58 ` Johan Hovold [this message]
2017-07-06 19:08 ` Dave Gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703165844.GD27842@localhost \
--to=johan@kernel.org \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).