From: Tony Lindgren <tony@atomide.com>
To: Roman Gushchin <guro@fb.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add tracepoints for oom reaper-related events)
Date: Sun, 16 Jul 2017 22:59:42 -0700 [thread overview]
Message-ID: <20170717055942.GA10026@atomide.com> (raw)
In-Reply-To: <20170716125354.GA20017@castle>
* Roman Gushchin <guro@fb.com> [170716 05:55]:
> On Fri, Jul 14, 2017 at 07:23:43PM +0200, Sebastian Reichel wrote:
> > Hi,
> >
> > On Fri, Jul 14, 2017 at 02:12:21PM +0000, Roman Gushchin wrote:
> > > > On 14 Jul 2017, at 14:43, Sebastian Reichel <sebastian.reichel@collabora.co.uk> wrote:
> > > > I just bisected another issue breaking boot on Droid 4. My
> > > > bisect points to 422580c3cea7 (mm/oom_kill.c: add tracepoints
> > > > for oom reaper-related events). It do not see any message
> > > > printed to UART (with earlyprintk) once that commit is part
> > > > of my image. Kernel config is below.
> >
> > > This is really interesting, because this patch adds few
> > > tracepoints and all of them are called from the oom code, which is
> > > hopefully not a part of the boot process.
> > >
> > > Can you, please, confirm, that it can be reproduced with some
> > > confidence? If so, can you, please, eliminate the tracepoints
> > > calls and try to reproduce the boot failure?
> >
> > I can boot 9967468c0a10 ("Merge branch 'akpm' (patches from
> > Andrew)") after adding
> >
> > - http://git.kernel.org/tip/19d39a3810e7032f311ef83effdac40339b9d022
> > (another issue, that breaks Droid 4 boot)
> > - a git revert of 422580c3cea7
> >
> > OTOH there are strange problems. Using da16dd9785f8 + above
> > two commits also works. Using b5e16170f59b + above commits
> > does not work and bisection ended up in the merge commit.
>
> Hi, Sebastian!
>
> As commit 422580c3cea7 hasn't added any code, which is executed
> during the boot process, I could imagine only two options:
> 1) Added code/data occasionally broke some alignment/size contraints.
> 2) There is another instable bug, which compromised bisect results.
>
> Unfortunately, I can't help you with reproducing, because I haven't
> necessary hardware.
>
> Can you, please, try some older known to be good revision with
> the 422580c3cea7 patch applied?
Sebastian, for me droid 4 boots just fine with v4.13-rc1 +
19d39a3810e if that helps. So that's with commit 422580c3cea7.
Regards,
Tony
next prev parent reply other threads:[~2017-07-17 5:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 13:43 Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add tracepoints for oom reaper-related events) Sebastian Reichel
2017-07-14 14:12 ` Roman Gushchin
2017-07-14 17:23 ` Sebastian Reichel
2017-07-16 12:53 ` Roman Gushchin
2017-07-17 5:59 ` Tony Lindgren [this message]
2017-07-17 9:51 ` Sebastian Reichel
2017-07-17 10:19 ` Tony Lindgren
2017-07-17 11:17 ` Sebastian Reichel
2017-07-17 11:51 ` Sebastian Reichel
2017-07-18 6:00 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717055942.GA10026@atomide.com \
--to=tony@atomide.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).