From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Johan Hovold <johan@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Dave Gerlach <d-gerlach@ti.com>,
Kevin Hilman <khilman@baylibre.com>, Nishanth Menon <nm@ti.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq
Date: Tue, 25 Jul 2017 00:10:49 -0700 [thread overview]
Message-ID: <20170725071048.GP10026@atomide.com> (raw)
In-Reply-To: <05ae4585-8da0-6fb1-8cfd-6b236ec3a8a2@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [170724 15:17]:
> My personal thought here is that removing of pm_runtime_set_active() will not fix
> root cause of the problem, but rather hide it :( and, probably, real fix will be
> to update USB framework to ensure that all suspend devices are also PM runtime suspend
> (not sure how) or add few more pm_suspend_ignore_children() calls
> (for example as I've tried to do in [2], but this was unfinished).
>
> I've found very simple steps to reproduce suspend failure on am335x-evm (should also
> work on BBB) - do below sequence with USB device plugged:
>
> echo platform > /sys/power/pm_test
> echo 1 > /sys/power/pm_print_times
> [ echo 0 > /sys/module/printk/parameters/console_suspend ]
> echo mem > /sys/power/state
>
> [ 95.499685] calling 47400000.usb+ @ 733, parent: ocp
> [ 95.504818] am335x-usb-childs 47400000.usb: runtime PM trying to suspend device but active child
> [ 95.513750] am335x-usb-childs 47400000.usb: omap device suspend failure 0
>
> Below I've attached possible patch which converts OMAP device to
> use pm_runtime_force_suspend/resume().
It seems to almost work for my PM test cases.. It seems that serial console
somehow won't get restored after suspend/resume cycle on omap3 though.
The system enters off mode during suspend, and wakes up properly so I can
ssh to it after resume. But the serial console no longer works after resume.
This is with 8250-omap driver.
Regards,
Tony
next prev parent reply other threads:[~2017-07-25 7:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 9:52 [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq Johan Hovold
2017-07-24 22:16 ` Grygorii Strashko
2017-07-25 7:10 ` Tony Lindgren [this message]
2017-07-25 8:56 ` Tony Lindgren
2017-07-25 17:41 ` Grygorii Strashko
2017-07-25 8:24 ` Johan Hovold
2017-07-25 17:48 ` Grygorii Strashko
2017-07-26 7:50 ` Johan Hovold
2017-07-26 8:17 ` Tony Lindgren
2017-07-26 8:35 ` Johan Hovold
2017-08-10 15:08 ` Tony Lindgren
2017-07-25 8:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725071048.GP10026@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).