From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/4] ARM: dts: tps65217: Add power button interrupt to the common tps65217.dtsi file Date: Thu, 10 Aug 2017 09:24:46 -0700 Message-ID: <20170810162446.GE8569@atomide.com> References: <20170612212412.22719-1-enric.balletbo@collabora.com> <20170612212412.22719-2-enric.balletbo@collabora.com> <20170613073519.GA3730@atomide.com> <20170614045551.GB3730@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170614045551.GB3730-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Enric Balletbo Serra Cc: Enric Balletbo i Serra , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-kernel , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , Russell King , Lee Jones , Sebastian Reichel , Grygorii Strashko , Javier Martinez Canillas List-Id: linux-omap@vger.kernel.org * Tony Lindgren [170613 22:00]: > * Enric Balletbo Serra [170613 02:12]: > > Hi Tony, > > > > 2017-06-13 9:35 GMT+02:00 Tony Lindgren : > > > * Enric Balletbo i Serra [170612 14:28]: > > >> The interrupt for power button is static data that comes from the > > >> datasheet, there is no reason to need to define this value on every > > >> board so seams reasonable put this information into the common tps65217 > > >> file. > > > > > > I think there's a problem with these patches where we no longer know > > > if the interrupts are wired up on a board. For example, if the USB PHY > > > VBUS interrupt is not connected, the phy driver needs poll the > > > cable state. > > > > > > > Hmm, the tps65217 doesn't have a USB PHY like others tps, so not sure > > how could affect this patch. Did you see this issue in any board that > > uses tps65217 or any am335x based board which commonly uses this pmic? > > Oh sorry I misread your patch. I thought you're removing > the interrupts from dts, but you're just moving the dts entries > to the common dtsi file :) So seems just fine with me. Applying patches 1 and 2 of this series into omap-for-v4.14/dt thanks. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html