From: Tony Lindgren <tony@atomide.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: OMAP4+: PRM: fix of_irq_get() result checks
Date: Mon, 14 Aug 2017 10:17:48 -0700 [thread overview]
Message-ID: <20170814171746.GY8569@atomide.com> (raw)
In-Reply-To: <2dfd399c-2760-7d64-a43f-caefde03b39a@cogentembedded.com>
* Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [170814 04:44]:
> On 08/10/2017 01:02 AM, Tony Lindgren wrote:
>
> > > > of_irq_get() may return 0 as well as a nagative error number on failure,
> > >
> > > Oops, forgot to kill comma...
> >
> > I can fix that while applying.
>
> Thanks!
>
> > > > (and never on success), however omap44xx_prm_late_init() regards 0 as a
> > > > valid IRQ -- fix this.
> > > >
> > > > Fixes: a8f83aefcd5a ("ARM: OMAP4+: PRM: register interrupt information from DT")
> > > > Fixes: c5b3955828ba ("ARM: OMAP4: Fix legacy code clean-up regression")
> > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > [...]
>
> > Seems these both should be safe to apply into fixes-not-urgent for
> > v4.14 merge window as we have not seen any issues with this? Or
>
> Yes, probably.
>
> > are there some known bugs related to this?
>
> Dunno, I was just auditing the call sites of of_irq_get[_byname]()...
OK thanks I'll apply both into omap-for-v4.14/fixes-not-urgent.
Tony
prev parent reply other threads:[~2017-08-14 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 15:14 [PATCH v2 2/2] ARM: OMAP4+: PRM: fix of_irq_get() result checks Sergei Shtylyov
2017-08-06 15:19 ` Sergei Shtylyov
2017-08-09 22:02 ` Tony Lindgren
2017-08-14 11:44 ` Sergei Shtylyov
2017-08-14 17:17 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814171746.GY8569@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=rnayak@codeaurora.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox