From: Stephen Boyd <sboyd@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Tero Kristo <t-kristo@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] clk: ti: check for null return in strrchr to avoid null dereferencing
Date: Thu, 31 Aug 2017 18:45:15 -0700 [thread overview]
Message-ID: <20170901014515.GW21656@codeaurora.org> (raw)
In-Reply-To: <20170726235627.9163-1-colin.king@canonical.com>
On 07/27, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> strrchr can potentially return a null so the following strlen on the
> null pointer can cause a null dereference. Add a check to see if
> the string postfix is not null before calling strlen.
>
> Detected by CoverityScan, CID#1452039 ("Dereference null return")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-09-01 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 23:56 [PATCH][next] clk: ti: check for null return in strrchr to avoid null dereferencing Colin King
2017-07-27 6:05 ` Tero Kristo
2017-09-01 1:45 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901014515.GW21656@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).