From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 2/2] iommu/omap: Add support to program multiple iommus Date: Fri, 1 Sep 2017 18:33:12 +0200 Message-ID: <20170901163312.GM19533@8bytes.org> References: <20170831131402.29502-1-s-anna@ti.com> <20170831131402.29502-3-s-anna@ti.com> <20170901100141.2ooccy7ns2fwxceg@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Suman Anna Cc: Tony Lindgren , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tero Kristo , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Laurent Pinchart , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org Hi Suman, On Fri, Sep 01, 2017 at 11:21:45AM -0500, Suman Anna wrote: > It's primarily a question of whether each iommu platform device need to > be represented as a unique iommu_device or not. If you still think that > both these need to be presented to iommu core as one device, I would > have to add some glue logic in probe to tie the two devices together. I think that you should only call iommu_device_register and friends for the mmu-device you link the other devices against in .add_device. Otherwise people will see two mmus in sysfs, one of them with no devices behind it. That is inconsistent with the rest of the patch-set, which basically handles bots mmus as one. But changing that should be easy, I think. Regards, Joerg