Re: drm_kms_helper cycle detected build error in next

Re: drm_kms_helper cycle detected build error in next

[Tony Lindgren]

* Tony Lindgren <tony@atomide.com> [171013 07:59]:
> Hi Tomi,
> 
> Looks like today's next build fails if omapdrm is enabled as modules
> with:
> 
> depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
> depmod: ERROR: Found 2 modules in dependency cycles!
> make: *** [Makefile:1261: _modinst_post] Error 1

Making CONFIG_DRM=y and CONFIG_DRM_KMS_HELPER=y instead of
lodable modules makes it build.

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm_kms_helper cycle detected build error in next

[Tomi Valkeinen]


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 13/10/17 18:09, Tony Lindgren wrote:

>> Looks like today's next build fails if omapdrm is enabled as modules
>> with:
>>
>> depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
>> depmod: ERROR: Found 2 modules in dependency cycles!
>> make: *** [Makefile:1261: _modinst_post] Error 1
> 
> Making CONFIG_DRM=y and CONFIG_DRM_KMS_HELPER=y instead of
> lodable modules makes it build.

The same happens even after disabling omapdrm, so it's somewhere in the
common code.

Interestingly, my depmod crashes when encountering this.

 Tomi

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm_kms_helper cycle detected build error in next

[Dave Airlie]

On 16 October 2017 at 16:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> On 13/10/17 18:09, Tony Lindgren wrote:
>
>>> Looks like today's next build fails if omapdrm is enabled as modules
>>> with:
>>>
>>> depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
>>> depmod: ERROR: Found 2 modules in dependency cycles!
>>> make: *** [Makefile:1261: _modinst_post] Error 1
>>
>> Making CONFIG_DRM=y and CONFIG_DRM_KMS_HELPER=y instead of
>> lodable modules makes it build.
>
> The same happens even after disabling omapdrm, so it's somewhere in the
> common code.
>
> Interestingly, my depmod crashes when encountering this.

There is a fix for this in drm-misc, I should probably pull it over.

If I haven't been sent a pull tomorrow, I'll grab it.

Dave.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm_kms_helper cycle detected build error in next

[Daniel Vetter]

On Mon, Oct 16, 2017 at 05:15:50PM +1000, Dave Airlie wrote:
> On 16 October 2017 at 16:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> >
> > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> >
> > On 13/10/17 18:09, Tony Lindgren wrote:
> >
> >>> Looks like today's next build fails if omapdrm is enabled as modules
> >>> with:
> >>>
> >>> depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
> >>> depmod: ERROR: Found 2 modules in dependency cycles!
> >>> make: *** [Makefile:1261: _modinst_post] Error 1
> >>
> >> Making CONFIG_DRM=y and CONFIG_DRM_KMS_HELPER=y instead of
> >> lodable modules makes it build.
> >
> > The same happens even after disabling omapdrm, so it's somewhere in the
> > common code.
> >
> > Interestingly, my depmod crashes when encountering this.
> 
> There is a fix for this in drm-misc, I should probably pull it over.
> 
> If I haven't been sent a pull tomorrow, I'll grab it.

You're too much ahead for a pull request on your Monday, but you'll get it
asap :-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm_kms_helper cycle detected build error in next

[Tony Lindgren]

* Daniel Vetter <daniel@ffwll.ch> [171016 02:18]:
> On Mon, Oct 16, 2017 at 05:15:50PM +1000, Dave Airlie wrote:
> > On 16 October 2017 at 16:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > >
> > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> > >
> > > On 13/10/17 18:09, Tony Lindgren wrote:
> > >
> > >>> Looks like today's next build fails if omapdrm is enabled as modules
> > >>> with:
> > >>>
> > >>> depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
> > >>> depmod: ERROR: Found 2 modules in dependency cycles!
> > >>> make: *** [Makefile:1261: _modinst_post] Error 1
> > >>
> > >> Making CONFIG_DRM=y and CONFIG_DRM_KMS_HELPER=y instead of
> > >> lodable modules makes it build.
> > >
> > > The same happens even after disabling omapdrm, so it's somewhere in the
> > > common code.
> > >
> > > Interestingly, my depmod crashes when encountering this.
> > 
> > There is a fix for this in drm-misc, I should probably pull it over.
> > 
> > If I haven't been sent a pull tomorrow, I'll grab it.
> 
> You're too much ahead for a pull request on your Monday, but you'll get it
> asap :-)

Meanwhile, can you guys provide few more clues which patch to pick
for the rest of us?

Something like patch subject line, commit id in drm-misc or something
along those lines would be nice..

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm_kms_helper cycle detected build error in next

[Daniel Vetter]

On Mon, Oct 16, 2017 at 07:35:24AM -0700, Tony Lindgren wrote:
> * Daniel Vetter <daniel@ffwll.ch> [171016 02:18]:
> > On Mon, Oct 16, 2017 at 05:15:50PM +1000, Dave Airlie wrote:
> > > On 16 October 2017 at 16:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > > >
> > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> > > >
> > > > On 13/10/17 18:09, Tony Lindgren wrote:
> > > >
> > > >>> Looks like today's next build fails if omapdrm is enabled as modules
> > > >>> with:
> > > >>>
> > > >>> depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
> > > >>> depmod: ERROR: Found 2 modules in dependency cycles!
> > > >>> make: *** [Makefile:1261: _modinst_post] Error 1
> > > >>
> > > >> Making CONFIG_DRM=y and CONFIG_DRM_KMS_HELPER=y instead of
> > > >> lodable modules makes it build.
> > > >
> > > > The same happens even after disabling omapdrm, so it's somewhere in the
> > > > common code.
> > > >
> > > > Interestingly, my depmod crashes when encountering this.
> > > 
> > > There is a fix for this in drm-misc, I should probably pull it over.
> > > 
> > > If I haven't been sent a pull tomorrow, I'll grab it.
> > 
> > You're too much ahead for a pull request on your Monday, but you'll get it
> > asap :-)
> 
> Meanwhile, can you guys provide few more clues which patch to pick
> for the rest of us?
> 
> Something like patch subject line, commit id in drm-misc or something
> along those lines would be nice..

I guess linux-next still not yet back to the daily update schedule, that's
why you need this? It's been in trees since last week, and now also in
drm-next ... Usually no one ever cares about the commit if we fix it right
away.

Anyway

commit 512721a14a2a94b48ca0863d48f9829922a816b8
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Fri Oct 13 16:08:53 2017 +0200

    drm/drm_of: Move drm_of_panel_bridge_remove_function into header.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm_kms_helper cycle detected build error in next

[Tony Lindgren]

* Daniel Vetter <daniel@ffwll.ch> [171017 05:09]:
> On Mon, Oct 16, 2017 at 07:35:24AM -0700, Tony Lindgren wrote:
> > 
> > Meanwhile, can you guys provide few more clues which patch to pick
> > for the rest of us?
> > 
> > Something like patch subject line, commit id in drm-misc or something
> > along those lines would be nice..
> 
> I guess linux-next still not yet back to the daily update schedule, that's
> why you need this? It's been in trees since last week, and now also in
> drm-next ... Usually no one ever cares about the commit if we fix it right
> away.
> 
> Anyway
> 
> commit 512721a14a2a94b48ca0863d48f9829922a816b8
> Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Date:   Fri Oct 13 16:08:53 2017 +0200
> 
>     drm/drm_of: Move drm_of_panel_bridge_remove_function into header.

OK thanks looks like Linux next is building for me again now.

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel