From: Borislav Petkov <bp@alien8.de>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
mchehab@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 2/3] EDAC: ti: add support for TI keystone and DRA7xx EDAC
Date: Thu, 9 Nov 2017 13:12:26 +0100 [thread overview]
Message-ID: <20171109121226.d63muafsaip74mvh@pd.tnic> (raw)
In-Reply-To: <5e88e7bb-911d-a157-ac1f-2b5cc9b0a554@ti.com>
On Thu, Nov 09, 2017 at 12:38:02PM +0200, Tero Kristo wrote:
> Yeah, the DRA7 SoCs have 2x emif instances, and ECC is only available on one
> (and it can be either enabled or disabled.) I thought it might be useful to
> have the dimm info populated for both in this case to avoid confusion and to
> be able to see the status from userspace.
>
> It is also possible to ditch that and only have dimm info for instances
> which have ECC enabled. Which way would you prefer?
Actually, having all DIMMs present, even if ECC is not enabled for a
subset of them, would make the picture more user-friendly. Yap, that's better.
> Thanks for review, and sorry again for missing the checkpatch.
No worries, that's what review is for. :)
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-11-09 12:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 20:38 [PATCH 0/3] EDAC: TI: add support for DRA7 and keystone EDAC Tero Kristo
2017-11-07 20:38 ` [PATCH 1/3] Documentation: dt: memory: ti-emif: add edac support under emif Tero Kristo
2017-11-10 8:25 ` [PATCHv2 2/3] EDAC: ti: add support for TI keystone and DRA7xx EDAC Tero Kristo
2017-11-11 10:46 ` Borislav Petkov
2017-11-13 9:03 ` Tero Kristo
[not found] ` <1510087139-21885-2-git-send-email-t-kristo-l0cyMroinI0@public.gmane.org>
2017-12-07 9:03 ` [PATCH 1/3] Documentation: dt: memory: ti-emif: add edac support under emif Tero Kristo
2017-11-07 20:38 ` [PATCH 2/3] EDAC: ti: add support for TI keystone and DRA7xx EDAC Tero Kristo
2017-11-09 10:14 ` Borislav Petkov
2017-11-09 10:38 ` Tero Kristo
2017-11-09 12:12 ` Borislav Petkov [this message]
2017-11-09 11:50 ` Jan Lübbe
2017-11-09 12:40 ` Tero Kristo
2017-11-13 13:08 ` [PATCHv3 " Tero Kristo
2017-11-13 17:10 ` Santosh Shilimkar
2017-11-13 17:58 ` Borislav Petkov
2017-11-13 18:04 ` Santosh Shilimkar
2017-11-13 18:08 ` Borislav Petkov
2017-11-13 18:49 ` Tero Kristo
2017-11-13 19:17 ` Santosh Shilimkar
2017-11-27 13:12 ` Borislav Petkov
2017-11-07 20:38 ` [PATCH 3/3] ARM: dts: Keystone: add ECC error handler support Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109121226.d63muafsaip74mvh@pd.tnic \
--to=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox