Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: USB regression in next-20171108 with hub spamming
Date: Thu, 9 Nov 2017 06:39:33 -0800	[thread overview]
Message-ID: <20171109143933.GA28152@atomide.com> (raw)
In-Reply-To: <87po8rra42.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

* Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> [171109 11:01]:
> Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> writes:
> > Okay, found it. Testing a patch.
> 
> Here's the patch, I'll send it formally shortly.

Thanks yeah that fixes the issue for me, replied to your formal
patch with a tested by.

Regards,

Tony

> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 0cdc463c9509..c15fbf76f8f7 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -975,6 +975,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target,
>  		}
>  
>  		*(u32 *) data = le32_to_cpu(*(__le32 *) status);
> +		ret = 0;
>  		break;
>  	case 2:
>  		if (type != USB_STATUS_TYPE_STANDARD) {
> @@ -983,6 +984,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target,
>  		}
>  
>  		*(u16 *) data = le16_to_cpu(*(__le16 *) status);
> +		ret = 0;
>  		break;
>  	default:
>  		ret = -EIO;
> -- 
> 2.14.2.642.g20fed7cad4
> 
> 
> -- 
> balbi


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-11-09 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 23:05 USB regression in next-20171108 with hub spamming Tony Lindgren
     [not found] ` <20171108230511.GY28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-11-09  8:00   ` Greg Kroah-Hartman
     [not found]     ` <20171109080007.GA17098-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-11-09 10:25       ` Felipe Balbi
     [not found]         ` <871sl7sq9i.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-09 10:44           ` Felipe Balbi
     [not found]             ` <87wp2zrasg.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-09 10:49               ` Felipe Balbi
     [not found]                 ` <87shdnrak7.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-09 10:59                   ` Felipe Balbi
     [not found]                     ` <87po8rra42.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-09 14:39                       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109143933.GA28152@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox