From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup Date: Mon, 13 Nov 2017 09:12:23 +0000 Message-ID: <20171113091223.til75bn3smopzjix@dell> References: <20171111153844.16741-1-johan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20171111153844.16741-1-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Johan Hovold Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable , Peter Ujfalusi List-Id: linux-omap@vger.kernel.org On Sat, 11 Nov 2017, Johan Hovold wrote: > A helper purported to look up a child node based on its name was using > the wrong of-helper and ended up prematurely freeing the parent of-node > while leaking any matching node. > > To make things worse, any matching node would not even necessarily be a > child node as the whole device tree was searched depth-first starting at > the parent. > > Fixes: 019a7e6b7b31 ("mfd: twl4030-audio: Add DT support") > Cc: stable # 3.7 > Cc: Peter Ujfalusi > --- > drivers/mfd/twl4030-audio.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones I'll pick this up later in the cycle. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog