From: Stephen Boyd <sboyd@codeaurora.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, tony@atomide.com
Subject: Re: [PATCHv2 04/28] clk: ti: clkctrl: use fallback udelay approach if timekeeping is suspended
Date: Mon, 13 Nov 2017 18:06:43 -0800 [thread overview]
Message-ID: <20171114020643.GU11955@codeaurora.org> (raw)
In-Reply-To: <1510218917-1725-2-git-send-email-t-kristo@ti.com>
On 11/09, Tero Kristo wrote:
> In certain cases it is possible that the timekeeping has been suspended
> already when attempting to disable/enable a clkctrl clock. This will
> happen at least on am43xx platform when attempting to enable / disable
> the clockevent source itself, burping out a warning from timekeeping core.
>
> The sequence of events leading to this:
> -> timekeeping_suspend()
> -> clockevents_suspend()
> -> omap_clkevt_idle()
> -> omap_hwmod_idle()
> -> _omap4_clkctrl_clk_disable()
> -> _omap4_is_timeout()
>
> Avoid the issue by checking if the timekeeping is suspended and using
> the fallback udelay approach for checking timeouts.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
No Cc on timekeeping maintainers, but OK.
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-14 2:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 9:15 [PATCHv2 00/28] clk: ti: clkctrl fixes + support for new SoCs Tero Kristo
2017-11-09 9:15 ` [PATCHv2 04/28] clk: ti: clkctrl: use fallback udelay approach if timekeeping is suspended Tero Kristo
2017-11-14 2:06 ` Stephen Boyd [this message]
2017-11-09 9:15 ` [PATCHv2 05/28] clk: ti: convert retry_init param to use void data type Tero Kristo
2017-11-14 2:07 ` Stephen Boyd
2017-11-09 9:15 ` [PATCHv2 06/28] clk: ti: clkctrl: add support for retrying failed init Tero Kristo
2017-11-14 2:07 ` Stephen Boyd
2017-11-09 9:15 ` [PATCHv2 23/28] clk: ti: am43xx: add clkctrl clock data Tero Kristo
2017-11-14 2:07 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114020643.GU11955@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).