Re: [PATCH v5 00/16] OMAP2+ OneNAND driver update

Aaro Koskinen
2018-01-11T19:29:31Z

Hi,

On Wed, Jan 10, 2018 at 10:13:25PM +0100, Ladislav Michl wrote:
> On Wed, Jan 10, 2018 at 07:35:19PM +0200, Aaro Koskinen wrote:
> > On Wed, Jan 10, 2018 at 10:20:58AM +0100, Ladislav Michl wrote:
> > > On Tue, Jan 09, 2018 at 11:01:14PM +0200, Aaro Koskinen wrote:
> > > > On Tue, Jan 09, 2018 at 02:08:12PM +0100, Ladislav Michl wrote:
> > > > > Merge window is really close now and patches seems still to be untested on
> > > > > n8x0. So unless someone is going to test it soon, I'll pick used N800 on
> > > > > ebay :-/
> > > >
> > > > Today I tried to test them on Nokia N810, and I get:
> > > >
> > > > [ 0.174804] omap-gpmc 6800a000.gpmc: GPMC revision 2.0
> > > > [ 0.174865] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000
> > > > [ 0.177459] omap-gpmc 6800a000.gpmc: /ocp/gpmc@6800a000/onenand@0,0 has no 'bank-width' property
> > > > [ 0.177612] omap-gpmc 6800a000.gpmc: failed to probe DT child 'onenand': -22
> > > >
> > > > With plain v4.15-rc7+ it probes fine.
> > >
> > > Thank you for testing. As stated in cover letter, you need also
> > > https://patchwork.kernel.org/patch/10043259/
> > > which can be also found in Roger's branch
> > > https://github.com/rogerq/linux/commits/for-v4.16/gpmc-omap-immutable
> > > (see previous replies in this thread and also discussion about OneNAND
> > > DT node)
> >
> > I applied it, and now get:
> >
> > [ 0.174987] omap-gpmc 6800a000.gpmc: GPMC revision 2.0
> > [ 0.175048] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000
> > [ 0.177703] omap-gpmc 6800a000.gpmc: Incompatible OneNAND node: missing compatible
> > [ 0.177764] omap-gpmc 6800a000.gpmc: failed to probe DT child 'onenand': -22
>
> As expected without reading discussion about OneNAND DT node :)
>
> In short, this version expects "ti,omap2-onenand" compatible.

Right. I didn't realize by bootloader was passing the DTB from an old
kernel.

So after fixing my boot I got the patches working N800 and N810: I was
able to read and write on old JFFS2 file systems without any issues. So
you can add for the series:

Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>

> In earlier version of this patchset there was fixup present, so driver
> worked even without compatible. Later on (17 Oct 2017 11:46:51 +0300)
> Roger objected (https://www.spinics.net/lists/linux-omap/msg139576.html):
> "I don't want to fixup broken DTs like this as they will go silently without
> being fixed. Let's instead just error out after the dev_warn(). This will
> force us to fix all DT nodes."
> So fixup was removed. I know N900 support is under heavy development
> in mainline, but if n8x0 is considered finished and stable, we should
> reintroduce fixup. Thoughts?

N8x0 support is also "under development", and we are fine with updating
and always using latest in-tree DTs.

A.