public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
To: Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Greg KH
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: EHCI and MUSB do not discover devices without CONFIG_PM
Date: Tue, 28 Nov 2017 10:42:45 +0100	[thread overview]
Message-ID: <20171128094245.GB21766@lenoch> (raw)
In-Reply-To: <87induzseh.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

On Tue, Nov 28, 2017 at 11:03:50AM +0200, Felipe Balbi wrote:
> Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> writes:
> > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote:
> >> On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote:
> >> > Hi there,
> >> > 
> >> > USB hosts do not discover any connected device on OMAP3 based board
> >> > with CONFIG_PM=n. Just enabling this option is enough to restore working
> >> > behaviour. Nothing unusual in log. Tested 4.14.2 and 4.15-rc1. I know
> >> > a lot of stuff depends on CONFIG_PM, but is this expected behaviour?
> >> > Neither EHCI nor MUSB is working without CONFIG_PM.
> >> 
> >> What bus type is your controllers on?  PCI?  platform?  Something else?
> >
> > Platform controllers inside OMAP3630 Soc.
> >
> >> And yes, perhaps this is to be expected, why would you not want
> >> CONFIG_PM to be enabled?  :)
> >
> > For a start, I know Linux is general purpose OS and I know I cannot expect
> > low latency or low jitter when dealing with interrupts.
> >
> > Original problem is described here:
> > https://www.spinics.net/lists/linux-omap/msg140081.html
> >
> > Shortly, with CONFIG_PM jitter of GPIO interrupt is about 350us which
> > renders IR receiver unuseable - is cannot reliably decode IR protocol
> > (gpio-ir-recv is used). With CONFIG_PM disabled, jitter is around 30us
> > and that's enough to make IR decoders work.
> >
> > And as I was unable to fix it, nor anyone provided useful hint, I though
> > I could work around problem from another side. And here we are...
> 
> Isn't it enough to just set a huge timeout for GPIO's runtime_pm? You
> can do that through sysfs. Just write a big number to the GPIO's
> autosuspend_delay_ms file. This should help you:

That does not help. And I already have Tony's hack in the patch stack:
https://patchwork.kernel.org/patch/9643499/
So this part of SoC is not powered off at all.

> modified   drivers/gpio/gpio-omap.c
> @@ -1238,6 +1238,8 @@ static int omap_gpio_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, bank);
>  
> +	pm_runtime_use_autosuspend(dev);
> +	pm_runtime_set_autosuspend_delay(dev, 60000);
>  	pm_runtime_enable(dev);
>  	pm_runtime_irq_safe(dev);
>  	pm_runtime_get_sync(dev);
> 
> 
> -- 
> balbi


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-11-28  9:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 22:08 EHCI and MUSB do not discover devices without CONFIG_PM Ladislav Michl
2017-11-28  7:33 ` Greg KH
     [not found]   ` <20171128073328.GF10757-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-11-28  8:57     ` Ladislav Michl
2017-11-28  9:03       ` Felipe Balbi
     [not found]         ` <87induzseh.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-28  9:42           ` Ladislav Michl [this message]
2017-11-28  9:30       ` Greg KH
     [not found]         ` <20171128093054.GA20720-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-11-28  9:39           ` Ladislav Michl
2017-11-28 14:11             ` Tony Lindgren
     [not found]               ` <20171128141131.GR28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-11-28 14:28                 ` Ladislav Michl
2017-11-28 14:39                   ` Tony Lindgren
     [not found]                     ` <20171128143913.GS28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-11-28 16:58                       ` Ladislav Michl
2017-11-28 17:16                         ` Tony Lindgren
2017-11-28 15:00     ` Alan Stern
     [not found]       ` <Pine.LNX.4.44L0.1711280956560.1467-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-11-28 16:05         ` Ladislav Michl
2017-11-28 18:09           ` Alan Stern
     [not found]             ` <Pine.LNX.4.44L0.1711281307250.1467-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-11-28 19:27               ` Ladislav Michl
2017-11-28 19:59                 ` Alan Stern
     [not found]                   ` <Pine.LNX.4.44L0.1711281452520.1467-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-11-28 20:14                     ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128094245.GB21766@lenoch \
    --to=ladis-6z/3iimg2c8g8few9mqtra@public.gmane.org \
    --cc=felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox