From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP2+: Handle errors from cpu_pm_enter() Date: Fri, 9 Feb 2018 12:54:22 -0800 Message-ID: <20180209205422.GC4383@atomide.com> References: <20180209174739.31072-1-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Grygorii Strashko Cc: Tero Kristo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dave Gerlach List-Id: linux-omap@vger.kernel.org * Grygorii Strashko [180209 20:09]: > On 02/09/2018 11:47 AM, Tony Lindgren wrote: > > @@ -196,18 +199,18 @@ static int omap_enter_idle_coupled(struct cpuidle_device *dev, > > } > > } > > - /* > > - * Call idle CPU PM exit notifier chain to restore > > - * VFP and per CPU IRQ context. > > - */ > > - cpu_pm_exit(); > > - > > /* > > * Call idle CPU cluster PM exit notifier chain > > * to restore GIC and wakeupgen context. > > */ > > if (dev->cpu == 0 && mpuss_can_lose_context) > > cpu_cluster_pm_exit(); > > +cpu_pm_out: > > + /* > > + * Call idle CPU PM exit notifier chain to restore > > + * VFP and per CPU IRQ context. > > + */ > > + cpu_pm_exit(); > > It looks ok, in general, but you've changed order of calls here, > so may be commit message need to be updated Hmm yeah good point, that's how it's usually done. I'll check and update the description like you suggested. Regards, Tony