From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 4/6] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler Date: Tue, 27 Mar 2018 15:23:49 -0700 Message-ID: <20180327222349.GK5700@atomide.com> References: <20180223101254.GA5746@lenoch> <20180223101553.GE5746@lenoch> <20180327215332.GC28163@mithrandir> <20180327221401.GD28163@mithrandir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180327221401.GD28163@mithrandir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Thierry Reding Cc: linux-pwm@vger.kernel.org, Ladislav Michl , aaro.koskinen@iki.fi, Keerthy , daniel.lezcano@linaro.org, t-kristo@ti.com, narmstrong@baylibre.com, sebastian.reichel@collabora.co.uk, robh+dt@kernel.org, Thomas Gleixner , Brecht Neyrinck , grygorii.strashko@ti.com, linux-omap@vger.kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org * Thierry Reding [180327 22:15]: > On Tue, Mar 27, 2018 at 11:53:33PM +0200, Thierry Reding wrote: > > On Fri, Feb 23, 2018 at 11:15:53AM +0100, Ladislav Michl wrote: > > > Prescaler setting is currently not taken into account. > > > Fix that by introducing freq member variable and initialize > > > it at device probe time. This also avoids frequency > > > recomputing at each pwm configure time. > > > > > > Signed-off-by: Ladislav Michl > > > --- > > > drivers/pwm/pwm-omap-dmtimer.c | 93 +++++++++++++++++++++++++----------------- > > > 1 file changed, 55 insertions(+), 38 deletions(-) > > > > Applied, thanks. > > Actually, that was a little premature. It seems like this conflicts with > a patch series by Keerthy that Tony merged into his tree and that you've > based this on. > > I think it'd be easiest if Tony merged this through the TI tree, or we > wait until v4.17-rc1 to resolve the dependency. Given how late we are in > the release cycle, I think it'd have to be the latter. Sorry about the extra hassle caused by the timer move to drivers. > Tony, if you think you can find a way to still take this in for > v4.17-rc1, feel free to do so: > > Acked-by: Thierry Reding I pretty much only apply fixes after -rc6. So let's wait for the dependencies to clear at this point. This seems like a "fix for a feature that never worked" so might be hard to justify it as a fix :) Ladis, can you please resend the pending patches again to Thierry after v4.17-rc? Then Thierry can queue it as a fix or for v4.18. Regards, Tony