Re: [PATCHv5 2/5] ASoC: codec: cpcap: new codec

Mark Brown
2018-02-27T11:03:15Z

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

On Fri, Feb 23, 2018 at 09:02:51PM +0100, Sebastian Reichel wrote:

> + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> + case SND_SOC_DAIFMT_I2S:
> + val |= BIT(CPCAP_BIT_ST_DIG_AUD_FS0);
> + val |= BIT(CPCAP_BIT_ST_DIG_AUD_FS1);
> + break;
> + default:
> + /* 01 - 4 slots network mode */
> + val |= BIT(CPCAP_BIT_ST_DIG_AUD_FS0);
> + val &= ~BIT(CPCAP_BIT_ST_DIG_AUD_FS1);
> + /* L on slot 1 */
> + val |= BIT(CPCAP_BIT_ST_L_TIMESLOT0);
> + break;
> + }

The default case here is really one specific mode, it looks like it's
either DSP_A or DSP_B. Most likely DSP_A but you should check.
Otherwise this looks good so I'll apply it, please send a followup patch
fixing this to match only the specific mode that's actually supported.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]