From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org
Cc: Nishanth Menon <nm@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Pavel Machek <pavel@ucw.cz>, Marcel Partap <mpartap@gmx.net>,
Dave Gerlach <d-gerlach@ti.com>,
Kalle Valo <kvalo@codeaurora.org>, Keerthy <j-keerthy@ti.com>,
Merlijn Wajer <merlijn@wizzup.org>,
Sebastian Reichel <sre@kernel.org>, Tero Kristo <t-kristo@ti.com>,
NeKit <nekit1000@gmail.com>, Eyal Reizer <eyalr@ti.com>,
Ash Charles <ash@gumstix.com>,
Michael Scott <hashcode0f@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: OMAP2+: Make sure LOGICRETSTATE bits are not cleared
Date: Thu, 17 May 2018 16:35:39 -0700 [thread overview]
Message-ID: <20180517233542.30629-2-tony@atomide.com> (raw)
In-Reply-To: <20180517233542.30629-1-tony@atomide.com>
We may have LOGICRETSTATE cleared by the bootloader or kexec boot.
Currently this means we will see lost GPIO interrupts at least for
network interfaces such as wlcore and smsc911x if PER hits retention.
Let's fix the issue by making sure LOGICRETSTATE is set. Once we have
GPIOs working with wakeirqs then we should be able to clear it.
Cc: Keerthy <j-keerthy@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/pm44xx.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -131,6 +131,19 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused)
return 0;
}
+ /*
+ * Bootloader or kexec boot may have LOGICRETSTATE cleared
+ * for some domains. This is the case when kexec booting from
+ * Android kernels that support off mode for example.
+ * Make sure it's set at least for core and per, otherwise
+ * we currently will see lost GPIO interrupts for wlcore and
+ * smsc911x at least if per hits retention during idle.
+ */
+ if (!strncmp(pwrdm->name, "core", 4) ||
+ !strncmp(pwrdm->name, "l4per", 5) ||
+ !strncmp(pwrdm->name, "wkup", 4))
+ pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_RET);
+
pwrst = kmalloc(sizeof(struct power_state), GFP_ATOMIC);
if (!pwrst)
return -ENOMEM;
--
2.17.0
next prev parent reply other threads:[~2018-05-17 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 23:35 [PATCH 0/4] Correct wlcore irqs for PM improvments for omap4 boards Tony Lindgren
2018-05-17 23:35 ` Tony Lindgren [this message]
2018-05-17 23:35 ` [PATCH 2/4] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt Tony Lindgren
2018-05-17 23:35 ` [PATCH 3/4] ARM: dts: Configure duovero for to allow core retention during idle Tony Lindgren
2018-05-17 23:35 ` [PATCH 4/4] omap4-droid4: Use software debounce for gpio-keys Tony Lindgren
2018-05-18 7:21 ` Pavel Machek
2018-05-18 14:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517233542.30629-2-tony@atomide.com \
--to=tony@atomide.com \
--cc=ash@gumstix.com \
--cc=d-gerlach@ti.com \
--cc=eyalr@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=hashcode0f@gmail.com \
--cc=j-keerthy@ti.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).