From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Marcel Partap <mpartap@gmx.net>,
Michael Scott <hashcode0f@gmail.com>, Keerthy <j-keerthy@ti.com>,
Merlijn Wajer <merlijn@wizzup.org>,
Dave Gerlach <d-gerlach@ti.com>,
Sebastian Reichel <sre@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>, NeKit <nekit1000@gmail.com>,
Eyal Reizer <eyalr@ti.com>, Ash Charles <ash@gumstix.com>,
Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] omap4-droid4: Use software debounce for gpio-keys
Date: Thu, 17 May 2018 16:35:42 -0700 [thread overview]
Message-ID: <20180517233542.30629-5-tony@atomide.com> (raw)
In-Reply-To: <20180517233542.30629-1-tony@atomide.com>
The default value of 5ms will use GPIO hardware based debounce clocks
that will keep L4PER from idling consuming about extra 30mW.
Use a value of 10ms that is above the hardware debounce maximum of
7.95ms forcing software based debouncing.
This allows droid4 to enter PER retention during idle as long as UARTs
are idled and USB modules unloaded or unbound.
Note that there seems to be a pending issue with having droid 4 enter core
retention during idle where GPIO bank 1 needs to be reset late after init
for some reason to not block core retention. In addition to that, we are
also missing GPIO related PM runtime calls for omap4 that will be posted
separately.
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Michael Scott <hashcode0f@gmail.com>
Cc: NeKit <nekit1000@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/omap4-droid4-xt894.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
--- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
+++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
@@ -128,6 +128,7 @@
gpios = <&gpio5 26 GPIO_ACTIVE_LOW>; /* gpio154 */
linux,code = <KEY_VOLUMEDOWN>;
linux,can-disable;
+ debounce-interval = <10>;
};
slider {
@@ -136,7 +137,7 @@
linux,input-type = <EV_SW>;
linux,code = <SW_KEYPAD_SLIDE>;
linux,can-disable;
-
+ debounce-interval = <10>;
};
};
--
2.17.0
next prev parent reply other threads:[~2018-05-17 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 23:35 [PATCH 0/4] Correct wlcore irqs for PM improvments for omap4 boards Tony Lindgren
2018-05-17 23:35 ` [PATCH 1/4] ARM: OMAP2+: Make sure LOGICRETSTATE bits are not cleared Tony Lindgren
2018-05-17 23:35 ` [PATCH 2/4] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt Tony Lindgren
2018-05-17 23:35 ` [PATCH 3/4] ARM: dts: Configure duovero for to allow core retention during idle Tony Lindgren
2018-05-17 23:35 ` Tony Lindgren [this message]
2018-05-18 7:21 ` [PATCH 4/4] omap4-droid4: Use software debounce for gpio-keys Pavel Machek
2018-05-18 14:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517233542.30629-5-tony@atomide.com \
--to=tony@atomide.com \
--cc=ash@gumstix.com \
--cc=d-gerlach@ti.com \
--cc=eyalr@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=hashcode0f@gmail.com \
--cc=j-keerthy@ti.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).