From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore Date: Tue, 22 May 2018 06:55:11 -0700 Message-ID: <20180522135511.GI98604@atomide.com> References: <20180517185029.71716-1-tony@atomide.com> <20180521163830.GZ98604@atomide.com> <20180521224339.GD98604@atomide.com> <38ddca4c73bb4dbf835a84133035dbfb@ti.com> <20180522133158.GE98604@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Reizer, Eyal" Cc: Kalle Valo , KISHON VIJAY ABRAHAM , "Mishol, Guy" , Luca Coelho , "Hahn, Maital" , "Altshul, Maxim" , Shahar Patury , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Loewy, Chen" List-Id: linux-omap@vger.kernel.org * Reizer, Eyal [180522 13:50]: > > > > OK try replacing the pm_runtime_put_noidle() above with just > > pm_runtime_put_sync(). The reason why I put noidle there was the > > wlcore_fw_sleep() call, with that gone put_sync should do the trick. > > > > I have tried that already. Same problem. The last call to: > ret = wlcore_raw_write32(wl, HW_ACCESS_ELP_CTRL_REG, ELPCTRL_SLEEP) > > which allows the firmware to get into ELP state during wowlan suspend is > only completing after system resume for some unknown reason... Hmm maybe try also adding wl1271_power_off(wl) after put_sync()? Regards, Tony