From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: ti_am335x_tscadc: Fix struct clk memory leak Date: Wed, 4 Jul 2018 08:58:39 +0100 Message-ID: <20180704075839.GR20176@dell> References: <1530678929-24482-1-git-send-email-zumeng.chen@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1530678929-24482-1-git-send-email-zumeng.chen@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Zumeng Chen Cc: rachna@ti.com, tony@atomide.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Wed, 04 Jul 2018, Zumeng Chen wrote: > Use devm_elk_get() to let Linux manage struct clk memory to avoid the following > memory leakage report: > > unreferenced object 0xdd75efc0 (size 64): > comm "systemd-udevd", pid 186, jiffies 4294945126 (age 1195.750s) > hex dump (first 32 bytes): > 61 64 63 5f 74 73 63 5f 66 63 6b 00 00 00 00 00 adc_tsc_fck..... > 00 00 00 00 92 03 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] kmemleak_alloc+0x40/0x74 > [] __kmalloc_track_caller+0x198/0x388 > [] kstrdup+0x40/0x5c > [] kstrdup_const+0x30/0x3c > [] __clk_create_clk+0x60/0xac > [] clk_get_sys+0x74/0x144 > [] clk_get+0x5c/0x68 > [] ti_tscadc_probe+0x260/0x468 [ti_am335x_tscadc] > [] platform_drv_probe+0x60/0xac > [] driver_probe_device+0x214/0x2dc > [] __driver_attach+0x94/0xc0 > [] bus_for_each_dev+0x90/0xa0 > [] driver_attach+0x28/0x30 > [] bus_add_driver+0x184/0x1ec > [] driver_register+0xb0/0xf0 > [] __platform_driver_register+0x40/0x54 > > Signed-off-by: Zumeng Chen > --- > drivers/mfd/ti_am335x_tscadc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog