From: Johan Hovold <johan@kernel.org>
To: Keerthy <j-keerthy@ti.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
t-kristo@ti.com, linux-rtc@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
johan@kernel.org
Subject: Re: [PATCH v4 3/4] rtc: omap: use of_device_is_system_power_controller function
Date: Thu, 19 Jul 2018 12:34:13 +0200 [thread overview]
Message-ID: <20180719103413.GS10204@localhost> (raw)
In-Reply-To: <1531372060-10532-4-git-send-email-j-keerthy@ti.com>
On Thu, Jul 12, 2018 at 10:37:39AM +0530, Keerthy wrote:
> Use of_device_is_system_power_controller instead of manually reading
> the system-power-controller property from the device tree node.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/rtc/rtc-omap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index cb19ece..3610efd 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -753,8 +753,7 @@ static int omap_rtc_probe(struct platform_device *pdev)
> if (of_id) {
> rtc->type = of_id->data;
> rtc->is_pmic_controller = rtc->type->has_pmic_mode &&
> - of_property_read_bool(pdev->dev.of_node,
> - "system-power-controller");
> + of_device_is_system_power_controller(pdev->dev.of_node);
Nit: Continuation lines should be indented at least two tabs further,
but in this case an exception seems warranted to keep the line within 80
cols.
> } else {
> id_entry = platform_get_device_id(pdev);
> rtc->type = (void *)id_entry->driver_data;
Reviewed-by: Johan Hovold <johan@kernel.org>
next prev parent reply other threads:[~2018-07-19 10:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 5:07 [PATCH v4 0/4] rtc: OMAP: Add support for rtc-only mode Keerthy
2018-07-12 5:07 ` [PATCH v4 1/4] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec Keerthy
2018-07-19 10:02 ` Johan Hovold
2018-07-19 11:53 ` Keerthy
2018-07-19 12:22 ` Keerthy
2018-07-19 12:36 ` Johan Hovold
2018-07-19 12:46 ` Keerthy
2018-07-20 10:33 ` Keerthy
2018-07-20 11:03 ` Johan Hovold
2018-07-19 10:23 ` Johan Hovold
2018-07-12 5:07 ` [PATCH v4 2/4] rtc: OMAP: Add support for rtc-only mode Keerthy
2018-07-19 10:29 ` Johan Hovold
2018-07-12 5:07 ` [PATCH v4 3/4] rtc: omap: use of_device_is_system_power_controller function Keerthy
2018-07-19 10:34 ` Johan Hovold [this message]
2018-07-12 5:07 ` [PATCH v4 4/4] rtc: interface: Add power_off_program to rtc_class_ops Keerthy
2018-07-19 10:40 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719103413.GS10204@localhost \
--to=johan@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).