* [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND_NONSTOP flag for non-am43 SoCs
@ 2018-08-07 9:25 Keerthy
2018-08-08 6:58 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Keerthy @ 2018-08-07 9:25 UTC (permalink / raw)
To: daniel.lezcano, tglx
Cc: linux-kernel, linux-omap, baolin.wang, d-gerlach, tony,
grygorii.strashko, j-keerthy, t-kristo
The 32k clocksource is NONSTOP for non-am43 SoCs. Hence
add the flag for all the other SoCs.
Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/clocksource/timer-ti-32k.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
index 29e2e1a..dd09171 100644
--- a/drivers/clocksource/timer-ti-32k.c
+++ b/drivers/clocksource/timer-ti-32k.c
@@ -97,6 +97,9 @@ static int __init ti_32k_timer_init(struct device_node *np)
return -ENXIO;
}
+ if (!of_machine_is_compatible("ti,am4372"))
+ ti_32k_timer.cs.flags |= CLOCK_SOURCE_SUSPEND_NONSTOP;
+
ti_32k_timer.counter = ti_32k_timer.base;
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND_NONSTOP flag for non-am43 SoCs
2018-08-07 9:25 [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND_NONSTOP flag for non-am43 SoCs Keerthy
@ 2018-08-08 6:58 ` Tony Lindgren
2018-08-08 13:10 ` J, KEERTHY
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2018-08-08 6:58 UTC (permalink / raw)
To: Keerthy
Cc: daniel.lezcano, tglx, linux-kernel, linux-omap, baolin.wang,
d-gerlach, grygorii.strashko, t-kristo
* Keerthy <j-keerthy@ti.com> [180807 09:29]:
> The 32k clocksource is NONSTOP for non-am43 SoCs. Hence
> add the flag for all the other SoCs.
>
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/clocksource/timer-ti-32k.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
> index 29e2e1a..dd09171 100644
> --- a/drivers/clocksource/timer-ti-32k.c
> +++ b/drivers/clocksource/timer-ti-32k.c
> @@ -97,6 +97,9 @@ static int __init ti_32k_timer_init(struct device_node *np)
> return -ENXIO;
> }
>
> + if (!of_machine_is_compatible("ti,am4372"))
> + ti_32k_timer.cs.flags |= CLOCK_SOURCE_SUSPEND_NONSTOP;
> +
> ti_32k_timer.counter = ti_32k_timer.base;
>
> /*
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND_NONSTOP flag for non-am43 SoCs
2018-08-08 6:58 ` Tony Lindgren
@ 2018-08-08 13:10 ` J, KEERTHY
2018-08-08 13:50 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: J, KEERTHY @ 2018-08-08 13:10 UTC (permalink / raw)
To: Tony Lindgren
Cc: daniel.lezcano, tglx, linux-kernel, linux-omap, baolin.wang,
d-gerlach, grygorii.strashko, t-kristo, Lokesh Vutla
On 8/8/2018 12:28 PM, Tony Lindgren wrote:
> * Keerthy <j-keerthy@ti.com> [180807 09:29]:
>> The 32k clocksource is NONSTOP for non-am43 SoCs. Hence
>> add the flag for all the other SoCs.
>>
>> Reported-by: Tony Lindgren <tony@atomide.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Thanks Tony. Lokesh pointed out about am43x-epos. So will make a minor
correction to this patch with compatible. I searched all the am4 boards
& seems like ti,am43 is the most generic compatible cover am43x-epos as
well. So i will retain your ack and send a v2 with am43 compatible
changed to a more generic ti,am43.
>
>> ---
>> drivers/clocksource/timer-ti-32k.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
>> index 29e2e1a..dd09171 100644
>> --- a/drivers/clocksource/timer-ti-32k.c
>> +++ b/drivers/clocksource/timer-ti-32k.c
>> @@ -97,6 +97,9 @@ static int __init ti_32k_timer_init(struct device_node *np)
>> return -ENXIO;
>> }
>>
>> + if (!of_machine_is_compatible("ti,am4372"))
>> + ti_32k_timer.cs.flags |= CLOCK_SOURCE_SUSPEND_NONSTOP;
>> +
>> ti_32k_timer.counter = ti_32k_timer.base;
>>
>> /*
>> --
>> 1.9.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND_NONSTOP flag for non-am43 SoCs
2018-08-08 13:10 ` J, KEERTHY
@ 2018-08-08 13:50 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2018-08-08 13:50 UTC (permalink / raw)
To: J, KEERTHY
Cc: daniel.lezcano, tglx, linux-kernel, linux-omap, baolin.wang,
d-gerlach, grygorii.strashko, t-kristo, Lokesh Vutla
* J, KEERTHY <j-keerthy@ti.com> [180808 13:14]:
>
>
> On 8/8/2018 12:28 PM, Tony Lindgren wrote:
> > * Keerthy <j-keerthy@ti.com> [180807 09:29]:
> > > The 32k clocksource is NONSTOP for non-am43 SoCs. Hence
> > > add the flag for all the other SoCs.
> > >
> > > Reported-by: Tony Lindgren <tony@atomide.com>
> > > Signed-off-by: Keerthy <j-keerthy@ti.com>
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
>
> Thanks Tony. Lokesh pointed out about am43x-epos. So will make a minor
> correction to this patch with compatible. I searched all the am4 boards &
> seems like ti,am43 is the most generic compatible cover am43x-epos as well.
> So i will retain your ack and send a v2 with am43 compatible changed to a
> more generic ti,am43.
OK makes sense to me thanks.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-08 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 9:25 [PATCH] clocksource: ti-32k: Add CLOCK_SOURCE_SUSPEND_NONSTOP flag for non-am43 SoCs Keerthy
2018-08-08 6:58 ` Tony Lindgren
2018-08-08 13:10 ` J, KEERTHY
2018-08-08 13:50 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).