From: Johan Hovold <johan@kernel.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: Johan Hovold <johan@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: ti: fix OF child-node lookup
Date: Fri, 31 Aug 2018 11:34:13 +0200 [thread overview]
Message-ID: <20180831093413.GK28861@localhost> (raw)
In-Reply-To: <4fbdbb5d-6b56-37e2-08e1-27f71cb6de22@ti.com>
On Thu, Aug 30, 2018 at 10:28:28AM +0300, Tero Kristo wrote:
> On 29/08/18 10:50, Johan Hovold wrote:
> > On Tue, Aug 28, 2018 at 03:32:03PM -0700, Stephen Boyd wrote:
> >> Quoting Johan Hovold (2018-08-22 02:03:19)
> >>> Fix child-node lookup which by using the wrong OF helper was searching
> >>> the whole tree depth-first, something which could end up matching an
> >>> unrelated node.
> >>>
> >>> Also fix the related node-reference leaks.
> >>>
> >>> Fixes: 5b385a45e001 ("clk: ti: add support for clkctrl aliases")
> >>
> >> Found by inspection? Or it's actively causing problems? I'm thinking
> >> it's the former so this can bake in clk-next for a while.
> >
> > Right, through inspection. I fixed up most of these last year, but this
> > one managed to sneak in since then.
> >
> > clk-next should be fine.
>
> The patch looks fine to me also, just had to test this out with my
> latest development branch as it conflicts with that one a bit.
>
> Acked-by: Tero Kristo <t-kristo@ti.com>
Thanks for reviewing.
Johan
next prev parent reply other threads:[~2018-08-31 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 9:03 [PATCH] clk: ti: fix OF child-node lookup Johan Hovold
2018-08-28 22:32 ` Stephen Boyd
2018-08-29 7:50 ` Johan Hovold
2018-08-30 7:28 ` Tero Kristo
2018-08-31 9:34 ` Johan Hovold [this message]
2018-08-30 21:46 ` Stephen Boyd
2018-09-20 7:11 ` Tero Kristo
2018-09-28 15:57 ` Stephen Boyd
2018-10-01 9:03 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831093413.GK28861@localhost \
--to=johan@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).