From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal Date: Tue, 4 Sep 2018 08:38:28 -0700 Message-ID: <20180904153828.GC5662@atomide.com> References: <20180902073058.17053-1-andreas@kemnade.info> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson Cc: Andreas Kemnade , Kishon , Wolfram Sang , "linux-mmc@vger.kernel.org" , linux-omap , Linux Kernel Mailing List , Discussions about the Letux Kernel List-Id: linux-omap@vger.kernel.org * Ulf Hansson [180904 14:39]: > On 2 September 2018 at 09:30, Andreas Kemnade wrote: > > after unbinding mmc I get things like this: > > [ 185.294067] mmc1: card 0001 removed > > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13 > > > > The wakeirq stays in /proc-interrupts > > > > rebinding shows this: > > [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup) > > [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ > > [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling > > > > That bug seems to be introduced by switching from devm_request_irq() > > to generic wakeirq handling. > > > > So let us cleanup at removal. > > > > Signed-off-by: Andreas Kemnade > > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq") Ooops sorry about that. > Applied for fixes, and added a stable tag, thanks! OK and thanks for fixing this Andreas! Regards, Tony