Re: [RFC PATCH 02/11] dt-bindings: phy: add cpsw port interface mode selection phy bindings

Grygorii Strashko
2018-10-09T20:10:34Z

On 10/09/2018 09:40 AM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [181008 23:54]:
>> +Examples:
>> + phy_gmii_sel: phy-gmii-sel {
>> + compatible = "ti,am3352-phy-gmii-sel";
>> + syscon-scm = <&scm_conf>;
>> + #phy-cells = <2>;
>> + };
>
> Now that this driver can live in it's proper place in the

right

> dts, you may want to consider just using standard reg
> property for it instead of the syscon-scm. And also get
> rid of the syscon reads and writes.

Could you help clarify how to get syscon in this case?
syscon_node_to_regmap(dev->parent->of_node)?

Also, there are could be more then one gmii_sel registers in SCM in the future,
so I hidden offsets in of_match data.
As result, "reg" not needed at all now.

--
regards,
-grygorii