Re: [PATCH v1 4/5] usb: dwc3: drd: Switch to device property for 'extcon' handling

Felipe Balbi
2018-11-12T11:47:10Z

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

Hi,

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> Switch to device property for 'extcon' handling.
> No functional change intended.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/usb/dwc3/drd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
> index e7e421521a34..5dc4cddd5b68 100644
> --- a/drivers/usb/dwc3/drd.c
> +++ b/drivers/usb/dwc3/drd.c
> @@ -10,6 +10,7 @@
> #include <linux/extcon.h>
> #include <linux/of_graph.h>
> #include <linux/platform_device.h>
> +#include <linux/property.h>
>
> #include "debug.h"
> #include "core.h"
> @@ -485,8 +486,8 @@ static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
> struct device_node *np_phy, *np_conn;
> struct extcon_dev *edev;
>
> - if (of_property_read_bool(dev->of_node, "extcon"))
> - return extcon_get_edev_by_phandle(dwc->dev, 0);
> + if (device_property_read_bool(dev, "extcon"))
> + return extcon_get_edev_by_phandle(dev, 0);

No reservations against any of the patches. What is the idea for getting
these merged upstream? I don't mind taking 4-5 through my tree, but what
are the other folks considering?

--
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]