public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Olof Johansson <olof@lixom.net>,
	guillaume.tucker@collabora.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ARM-SoC Maintainers <arm@kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL] ARM: SoC fixes
Date: Mon, 12 Nov 2018 09:33:39 -0800	[thread overview]
Message-ID: <20181112173339.GA53235@atomide.com> (raw)
In-Reply-To: <20181112061324.GA28680@Red>

* Corentin Labbe <clabbe.montjoie@gmail.com> [181112 06:13]:
> On Sat, Nov 10, 2018 at 10:09:19AM -0800, Olof Johansson wrote:
> > On Thu, Nov 8, 2018 at 7:49 AM Tony Lindgren <tony@atomide.com> wrote:
> > >
> > > * Olof Johansson <olof@lixom.net> [181107 09:28]:
> > > > On Wed, Nov 7, 2018 at 9:17 AM Linus Torvalds
> > > > <torvalds@linux-foundation.org> wrote:
> > > > >
> > > > > On Wed, Nov 7, 2018 at 9:10 AM Olof Johansson <olof@lixom.net> wrote:
> > > > > >
> > > > > > ARM: SoC fixes
> > > > >
> > > > > Pulled.
> > > > >
> > > > > > I was a bit too trigger happy to enable PREEMPT on multi_v7_defconfig,
> > > > > > and it ended up regressing at least BeagleBone XM boards.
> > > > >
> > > > > Odd. Did it hit some "may_sleep()" test in a driver that is hidden by
> > > > > preempt being off? Otherwise I don't see how/why preempt should fail
> > > > > in a board-specific manner..
> > > >
> > > > The board hangs early during boot and the usual way of collecting
> > > > early console doesn't seem to work when attempted (I haven't tried
> > > > personally).
> > > >
> > > > It's one of the major non-SMP platforms covered by tests. I'd be
> > > > surprised if it turns out to be truly _board_ specific (and rather
> > > > specific to OMAP3), but we don't have enough data yet. Chances are it
> > > > either shuffles some timing around or indeed hits a may_sleep() test
> > > > somewhere.
> > > >
> > > > (I just realized I might have missed to attribute Guillaume in the
> > > > revert patch. Sorry about that).
> > >
> > > Looks like we're missing the stdout-path for earlycon, maybe try
> > > with the following patch? I can't find my Beagleboard-xm right now,
> > > time to clean-up a bit I guess.
> > >
> > > At least omap3-evm, logicpd-torpedo and n900 all boot with PREEMPT.
> > 
> > To follow up on this, it turned out to be an issue where the kernel
> > outgrew the location it was loaded to, and overwrite the device tree
> > on decompression. So, not a code issue.
> > 
> > It's a known fragile aspect on some of the u-boot setups, and
> > something I've been hit by myself on my farm a few times.
> > 
> > Still, for now we'll keep PREEMPT off until next merge window.
> > 
> 
> Hello
> 
> Note that CONFIG_PREEMPT cause some errors also on sun8i-a83t-bananapi-m3
> Already reported https://lkml.org/lkml/2017/12/29/139

Also thread "[PATCH v1 1/5] drivercore: Revert "deferral race condition fix"
is reverting commit 58b116bce136 ("drivercore: deferral race condition fix")
which has CONFIG_PREEMPT mentioned in the log. So more testing is
probably needed in Linux next before enabling CONFIG_PREEMPT again.

Regards,

Tony

      reply	other threads:[~2018-11-12 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181107171023.zoo6qox5eewy3pmk@localhost>
     [not found] ` <CAHk-=whF7kBo49-BFTUc-by+HB_0qNw_=+d24TydO2mYwwsWMQ@mail.gmail.com>
     [not found]   ` <CAOesGMg3uHJ7YB95skjcVK39kudAGGjKo6909d--LDZmqeE1HA@mail.gmail.com>
2018-11-08 15:49     ` [GIT PULL] ARM: SoC fixes Tony Lindgren
2018-11-10 18:09       ` Olof Johansson
2018-11-12  6:13         ` Corentin Labbe
2018-11-12 17:33           ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181112173339.GA53235@atomide.com \
    --to=tony@atomide.com \
    --cc=arm@kernel.org \
    --cc=clabbe.montjoie@gmail.com \
    --cc=guillaume.tucker@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox