Re: [PATCH 1/2] phy: core: Add phy_pm_runtime_enabled

Pavel Machek
2019-06-02T10:14:34Z

Hi!

> > > The phy driver may need to check phy_pm_runtime_enabled() in suspend as
> > > PM runtime for phy may be already disabled when phy power_off() is called.
> > >
> > > Cc: Pavel Machek <pavel@ucw.cz>
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > ---
> > > drivers/phy/phy-core.c | 9 +++++++++
> > > include/linux/phy/phy.h | 6 ++++++
> > > 2 files changed, 15 insertions(+)
> > >
> > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> > > --- a/drivers/phy/phy-core.c
> > > +++ b/drivers/phy/phy-core.c
> >
> > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> > > --- a/include/linux/phy/phy.h
> > > +++ b/include/linux/phy/phy.h
> > > @@ -158,6 +158,7 @@ int phy_pm_runtime_get(struct phy *phy);
> > > int phy_pm_runtime_get_sync(struct phy *phy);
> > > int phy_pm_runtime_put(struct phy *phy);
> > > int phy_pm_runtime_put_sync(struct phy *phy);
> > > +bool phy_pm_runtime_enabled(struct phy *phy);
> > > void phy_pm_runtime_allow(struct phy *phy);
> > > void phy_pm_runtime_forbid(struct phy *phy);
> > > int phy_init(struct phy *phy);
> > > @@ -240,6 +241,11 @@ static inline int phy_pm_runtime_put_sync(struct phy *phy)
> > > return -ENOSYS;
> > > }
> > >
> > > +static inline bool phy_pm_runtime_enabled(struct phy *phy)
> > > +{
> > > + return false
> >
> > Missing semicolon.
>
> Oops thanks for catching that. I guess I did not try building
> without CONFIG_GENERIC_PHY. Will fix and repost.

Did this series get lost/forgotten somewhere? Is it still needed? Any
way I can help?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html