From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: omap5 fixing palmas IRQ_TYPE_NONE warning leads to gpadc timeouts Date: Tue, 27 Nov 2018 10:17:46 -0800 Message-ID: <20181127181746.GU53235@atomide.com> References: <20181119161906.GP53235@atomide.com> <20181119171406.GQ53235@atomide.com> <725df8e7-4aff-3751-d0b0-809b89e882e5@nvidia.com> <20181123164827.GE53235@atomide.com> <20181126093625.GA10878@ulmo> <20181126102541.GC10878@ulmo> <20181126193212.GN53235@atomide.com> <149b3b6b-e52e-4942-151b-6df4358f5a7a@nvidia.com> <20181127175538.GS53235@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181127175538.GS53235@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Jon Hunter Cc: Thierry Reding , Peter Ujfalusi , Belisko Marek , LKML , linux-omap@vger.kernel.org, "Dr. H. Nikolaus Schaller" , Laxman Dewangan List-Id: linux-omap@vger.kernel.org * Tony Lindgren [181127 17:55]: > The only option that works for omap5 at palmas end is if > PALMAS_POLARITY_CTRL_INT_POLARITY is cleared. Setting the SoC internal > pulls does not make a difference, so I suspect there is either some > unknown pull-up/pull-down configuration register in palmas, or there > is an external pull resistor. Remuxing the palmas interrupt to gpio_wk16 instead of sys_nirq1 makes the palmas interrupt work just fine configured with active-low or active-high with the internal pulls. So palmas.c is doing the right thing, and the issue configuring palmas interrupt active-high with sys_nirq1 on omap5 is somewhere between omap wkupegen and GIC. Regards, Tony