From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 11/14] media: wl128x-radio: fix skb debug printing Date: Sat, 22 Dec 2018 20:30:43 +0100 Message-ID: <20181222193043.GB15237@amd> References: <20181221011752.25627-1-sre@kernel.org> <20181221011752.25627-12-sre@kernel.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="K8nIJk4ghYZn606h" Return-path: Content-Disposition: inline In-Reply-To: <20181221011752.25627-12-sre@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Sebastian Reichel Cc: Mauro Carvalho Chehab , Marcel Holtmann , Tony Lindgren , Rob Herring , Greg Kroah-Hartman , linux-bluetooth@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel List-Id: linux-omap@vger.kernel.org --K8nIJk4ghYZn606h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2018-12-21 02:17:49, Sebastian Reichel wrote: > From: Sebastian Reichel >=20 > This fixes incorrect code in the TX/RX skb debug print > function and add stubs in receive/transmit packet path. >=20 > Signed-off-by: Sebastian Reichel Acked-by: Pavel Machek > @@ -228,7 +228,7 @@ inline void dump_rx_skb_data(struct sk_buff *skb) > =20 > evt_hdr =3D (struct fm_event_msg_hdr *)skb->data; > printk(KERN_INFO ">> hdr:%02x len:%02x sts:%02x numhci:%02x opcode:%02x= type:%s dlen:%02x", > - evt_hdr->hdr, evt_hdr->len, > + evt_hdr->header, evt_hdr->len, > evt_hdr->status, evt_hdr->num_fm_hci_cmds, evt_hdr->op, > (evt_hdr->rd_wr) ? "RD" : "WR", evt_hdr->dlen); Would conversion to dev_info() make sense? --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --K8nIJk4ghYZn606h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwekOMACgkQMOfwapXb+vIKIwCgrEkbjy5t+tLiU373RR0newf3 BH0An1W/Dah7XYAutH/TzzwChhwRkz44 =xgD7 -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--