From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Kemnade Subject: Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops Date: Mon, 31 Dec 2018 09:30:21 +0100 Message-ID: <20181231092944.014fc1c0@aktux> References: <154356242517.88331.8496814814468751012@swboyd.mtv.corp.google.com> <9eb7b090-4803-d389-4112-3bf058385b2e@ti.com> <154356463284.88331.13323307899580657085@swboyd.mtv.corp.google.com> <20181130153729.GG53235@atomide.com> <154362191595.88331.15503578806026771935@swboyd.mtv.corp.google.com> <20181203153910.GA6707@atomide.com> <20181203172246.0e767a16@kemnade.info> <20181204164556.GB6707@atomide.com> <20181227211222.5996c356@aktux> <20181228200229.GY6707@atomide.com> <76d9fc57-898b-53ba-1dca-78e5b5c9b2be@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/uU6bRmK+3X7C1R5FajkKT9V"; protocol="application/pgp-signature" Return-path: In-Reply-To: <76d9fc57-898b-53ba-1dca-78e5b5c9b2be@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Tero Kristo Cc: Tony Lindgren , Stephen Boyd , bcousson@baylibre.com, letux-kernel@openphoenux.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, mturquette@baylibre.com, paul@pwsan.com List-Id: linux-omap@vger.kernel.org --Sig_/uU6bRmK+3X7C1R5FajkKT9V Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 31 Dec 2018 09:23:01 +0200 Tero Kristo wrote: > On 28/12/2018 22:02, Tony Lindgren wrote: > > * Andreas Kemnade [181227 20:13]: =20 > >> Hi, > >> > >> On Tue, 4 Dec 2018 08:45:57 -0800 > >> Tony Lindgren wrote: > >> =20 > >>> * Andreas Kemnade [181204 06:17]: =20 > >>>> On Mon, 3 Dec 2018 07:39:10 -0800 > >>>> Tony Lindgren wrote: =20 > >>>>> The consumer device stays active just fine with PM runtime > >>>>> calls. So yes, the problem is keeping a clock controller forced > >>>>> active for the period of consumer device reset. Other than > >>>>> that typically autoidle can be just kept enabled. > >>>>> =20 > >>>> Are we still talking about the same problem? Maybe I am losing track > >>>> here. Just to make sure. > >>>> The patch series was about disabling autoidle for devices which cann= ot > >>>> work with it during normal operation. Not during reset or something > >>>> like that. > >>>> Or is the keep-clock-active-during-reset just a requirement for bigg= er > >>>> restructuring ideas? =20 > >>> > >>> Yeah there are two issues: The fix needed for the issue you brought u= p, > >>> and also how to let a reset driver to block autoidle for reset. > >>> =20 > >> Hmm, is this set now waiting for the famous "somebody" fixing all > >> the stuff? =20 > >=20 > > Well I think we're still waiting on Tero to comment on this. =20 >=20 > The only item requiring immediate fixing is the point Stephen made out,=20 > removing the usage of CLK_IS_BASIC from this patch. >=20 > Afaics, the reset related concerns Tony has can be handled later. >=20 hmm, and there we need Stephen's opinion about having the allow/deny autoidle functions in the main clk_ops struct. Regards, Andreas --Sig_/uU6bRmK+3X7C1R5FajkKT9V Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE7sDbhY5mwNpwYgrAfb1qx03ikyQFAlwp050ACgkQfb1qx03i kyR0Yg/9Ez4PEKEZaVe/qnywZub7XESAii40MAwGrsvUC727+M/xPzpupttLutZl SCF4QgDq+TpLd3xsRlx6IJZzux7hoLa29R+cAMz7YFkGbKxlZtVEydLcq4jWQfVs yuNYi6WZriYAg5rBqhlqLWi0h162ELJzPOiuZN56aj6sizGFqaeCOyvGHIZJF5lo NCazBMBiszNuCuk8W6V6vcqmyDDQY6EA2olIZUV8oThTcjETYuN0O9+9Yhr3Clzr Hgztmk3zKA7B1Bi0G1irdgg4uF9MhMEkhtaNC5xTRtU7pFXoYoS1V40P6wtLxb6d UI2tmbIBH4k9t4PqF+wt2Ly9FQn3xnDS1sZ4/qJWwhUluTM55r76o65DRfwHaj+Y AZFccX3LS6ck6CA8T5SziUxuzUrBuGtMjhGEtrk23MvaZr942lMuYeJ16Kblh4tk 7yOpuUNt3wbXJZ32kUkMjgzUjs6/kua4YNXJW7t//ZLR5xZw5qSPZYF9DYd0yBcR qzLQicqUq3DUs4RxA4i/9cf/h3Pp9sAnntw5k6pDYZcbgBeik4Ue3A4DPMl5FQK+ I+Nf/I7sXlSDtd+po4dDmBpo+ZtCAgRaVwfHWMHOAnUfaqH497dz6VZqzCHEQeoq 73zXbWMzrhk5fuordHOn98raOsDibCuJNFxuByNQxhLLkEDxsMc= =ypiE -----END PGP SIGNATURE----- --Sig_/uU6bRmK+3X7C1R5FajkKT9V--